Do not link removed pull request files - #2099
Merged
ymichael merged 1 commit intoAug 20, 2026
Merged
Conversation
ymichael
deleted the
bb/post-merge-fix-removed-pr-files-open-missing-pat-thr_9pd89n5iv6
branch
August 20, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
FileDiffCardrendered every pull-request file path as a live workspace link whenever the thread had an environment, without consideringfile.status. A removed file normally no longer exists in that workspace, so its filename advertised a preview target guaranteed to fail even though the separate diff control already exposed the deletion. This confirms the post-merge review finding.What changed
file.statusisremoved, while retainingexperimental_FileLinkfor statuses whose path can exist.How you verified
pnpm exec turbo run test --filter=bb-plugin-github --force -- app.test.tsxfailed the new regression withremoved.tsrendered as<a href="removed.ts">(1 failed, 2 passed).origin/main,pnpm exec turbo run test --filter=bb-plugin-github --forcepassed 6 files / 25 tests.pnpm exec turbo run typecheck --filter=bb-plugin-githubpassed.pnpm exec turbo run build --filter=bb-plugin-githubpassed and built the GitHub plugin's server and app artifacts.pnpm exec prettier --check plugins/github/app.test.tsxandgit diff --check origin/main...HEADpassed.Fixes: no matching issue.