Skip to content

Include project dot paths in file listings - #2103

Draft
ScaleLeanChris wants to merge 1 commit into
get-bb:mainfrom
ScaleLeanChris:bb/fix-2093-hidden-project-files-in-path-search-thr_zbacnmahs5
Draft

Include project dot paths in file listings#2103
ScaleLeanChris wants to merge 1 commit into
get-bb:mainfrom
ScaleLeanChris:bb/fix-2093-hidden-project-files-in-path-search-thr_zbacnmahs5

Conversation

@ScaleLeanChris

Copy link
Copy Markdown

What was wrong

The host daemon's shared recursive file walker skipped every entry whose name started with .. Both host.list_paths and host.list_files use that walker, so ordinary project files such as .github/workflows/ci.yml never reached file search even though the file read API could read them. See #2093.

What changed

  • Replace the broad dot-name exclusion with explicit exclusions for .git and node_modules.
  • Continue to skip recursive symlinks.
  • Add a regression test that includes .github/workflows/ci.yml and .env while excluding .git/config and a dependency file under node_modules.
  • Increase HOST_DAEMON_PROTOCOL_VERSION from 146 to 147 because the returned RPC path set changes.
  • Leave host.browse_directory unchanged. That single-level remote folder picker starts at the host home directory and should continue hiding home dot entries.

This deliberately does not add the issue's proposed caller-configurable wire fields. The narrower policy fixes normal project discovery without expanding the public API. No CLI, guide, SDK, or route shape changed.

How you verified

  • Before implementation, the new regression test failed with no dot paths returned. After implementation, pnpm exec turbo run test --filter=@bb/host-daemon -- --run src/command-handlers/file-list.test.ts passed 15 tests.
  • pnpm exec turbo run test --filter=@bb/host-daemon-contract -- --run test/contract.test.ts passed 38 tests.
  • pnpm exec turbo run typecheck build --filter=@bb/host-daemon --filter=@bb/host-daemon-contract --force passed all 7 Turbo tasks.
  • A manual post-fix walker probe returned .github/workflows/ci.yml and omitted .git/config and node_modules/pkg/index.js.
  • git diff --check passed.

Two unrelated full-suite assertions remain environment-sensitive in this managed worktree. The host-daemon suite passed 556 tests and failed the detached-process cleanup test, which also failed alone. The host-daemon-contract suite passed 51 tests and failed an exact gzip-size fixture by 1 to 4 bytes under the local zlib runtime. Neither failure imports or exercises the changed listing behavior.

Fixes #2093

AGENT GENERATED: by GPT-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path listing hides every dotfile and node_modules unconditionally, so file search cannot find .github/workflows/ci.yml

1 participant