Include project dot paths in file listings - #2103
Draft
ScaleLeanChris wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The host daemon's shared recursive file walker skipped every entry whose name started with
.. Bothhost.list_pathsandhost.list_filesuse that walker, so ordinary project files such as.github/workflows/ci.ymlnever reached file search even though the file read API could read them. See #2093.What changed
.gitandnode_modules..github/workflows/ci.ymland.envwhile excluding.git/configand a dependency file undernode_modules.HOST_DAEMON_PROTOCOL_VERSIONfrom 146 to 147 because the returned RPC path set changes.host.browse_directoryunchanged. That single-level remote folder picker starts at the host home directory and should continue hiding home dot entries.This deliberately does not add the issue's proposed caller-configurable wire fields. The narrower policy fixes normal project discovery without expanding the public API. No CLI, guide, SDK, or route shape changed.
How you verified
pnpm exec turbo run test --filter=@bb/host-daemon -- --run src/command-handlers/file-list.test.tspassed 15 tests.pnpm exec turbo run test --filter=@bb/host-daemon-contract -- --run test/contract.test.tspassed 38 tests.pnpm exec turbo run typecheck build --filter=@bb/host-daemon --filter=@bb/host-daemon-contract --forcepassed all 7 Turbo tasks..github/workflows/ci.ymland omitted.git/configandnode_modules/pkg/index.js.git diff --checkpassed.Two unrelated full-suite assertions remain environment-sensitive in this managed worktree. The host-daemon suite passed 556 tests and failed the detached-process cleanup test, which also failed alone. The host-daemon-contract suite passed 51 tests and failed an exact gzip-size fixture by 1 to 4 bytes under the local zlib runtime. Neither failure imports or exercises the changed listing behavior.
Fixes #2093