Keep T3 Sidebar child menus inside compact viewports - #2108
Open
Willhong wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Standalone implementation counterpart: SawyerHood/bb-plugin-t3sidebar#5 |
Willhong
marked this pull request as ready for review
August 20, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
T3 Sidebar unconditionally positioned its
20remchild menu withabsolute right-0relative to the header chip. Compact headers can place that chip farther left than the menu width, producing a negative left edge and clipping the menu outside the viewport. Fixes #2104. Standalone counterpart: SawyerHood/bb-plugin-t3sidebar#3.What changed
absolute right-0).20remmaximum width and the trigger's preferred right alignment.How you verified
pnpm exec turbo run test typecheck --filter=bb-plugin-t3sidebar— 83 tests passed; typecheck passed.absolute right-0 w-80.Fixes #2104