Fix T3 Sidebar long child-menu scrolling - #2109
Open
Willhong wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Standalone implementation counterpart: SawyerHood/bb-plugin-t3sidebar#6 |
Willhong
marked this pull request as ready for review
August 20, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
T3 Sidebar rendered every child in an uncapped menu and an ordinary
ul. With enough children, the menu extended beyond the thread viewport, but the list had no scroll range, so lower children were unreachable with both a desktop wheel and compact touch input. Fixes #2105. Standalone counterpart: SawyerHood/bb-plugin-t3sidebar#4.What changed
32remand the available dynamic viewport height.min-h-0,overflow-y-autoscroll region.How you verified
pnpm exec turbo run test typecheck --filter=bb-plugin-t3sidebar— 81 tests passed in the scroll-only iteration; typecheck passed.scrollTop = 0scrollTop = 500Fixes #2105