chore(examples): honor DEACON_BIN and ignore generated runtime artifacts#178
Merged
Conversation
Replace hardcoded `cargo run -p deacon --` with `"$DEACON_BIN"` (defaulting to `deacon` on PATH) across all read-configuration example scripts, matching the pattern already used by the rest of the examples tree. Lets the suite run against an installed binary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Running up/build examples writes lifecycle state (.devcontainer-state/) and build cache (.devcontainer/build-cache/) into the example's workspace folder. The existing /.devcontainer-state ignore was anchored to the repo root, so these polluted git status under examples/. Add tree-wide ignores for both generated paths. Verified the committed root .devcontainer-state/ test fixtures remain tracked and the 34 committed examples/**/.devcontainer/devcontainer.json configs are unaffected (only the build-cache subdir is ignored). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two examples-hygiene fixes, surfaced while validating the released
deacon 0.2.0-rc.1binary against the example suite:Honor
DEACON_BINinread-configurationscripts. The 9read-configuration/*/exec.shscripts hardcodedcargo run -p deacon --, forcing a source build. They now use"$DEACON_BIN"(defaulting todeaconon PATH), matching the pattern already used across the rest ofexamples/. This lets the whole suite run against an installed/release binary viaDEACON_BIN=....Ignore devcontainer runtime artifacts tree-wide. Running
up/buildexamples writes lifecycle state (.devcontainer-state/) and build cache (.devcontainer/build-cache/) into the example's workspace folder. The existing/.devcontainer-stateignore was anchored to the repo root, so these pollutedgit statusunderexamples/. Added tree-wide ignores for both.Verification
deacon 0.2.0-rc.1binary withDEACON_BIN=deacon:read-configuration(10),doctor(3),configuration(4)build/basic-dockerfile,up/basic-image,exec/non-interactive-streaming,down/basic— full build → up → exec → down lifecycle.devcontainer-state/test fixtures remain tracked and the 34 committedexamples/**/.devcontainer/devcontainer.jsonconfigs are unaffected (only thebuild-cachesubdir is ignored).git statusstays clean.🤖 Generated with Claude Code