Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies dependency and type fixes needed after Yarn dependency deduplication, primarily updating lru-cache usage in @appland/scanner and updating Node typings in @appland/client to keep TypeScript builds and formatting clean.
Changes:
- Update
@appland/scannertolru-cachev10 (remove@types/lru-cache, switch to named import, tighten cache value typing). - Update
@appland/clientto use@types/nodev18 to resolve type conflicts (notably aroundAbortSignal). - Apply Prettier/formatting fixes surfaced by updated package types.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/scanner/src/scan.ts | Switch lru-cache import to v10-compatible named import. |
| packages/scanner/src/configuration/configurationProvider.ts | Fix TypeScript indexed access typing syntax for rule.Options. |
| packages/scanner/src/appMapIndex.ts | Switch lru-cache import and tighten cached AST type to NonNullable<QueryAST>. |
| packages/scanner/package.json | Remove @types/lru-cache and bump lru-cache dependency to ^10. |
| packages/components/src/components/trace/TraceEventBlock.vue | Prettier-driven selector formatting adjustment. |
| packages/client/package.json | Bump @types/node to ^18. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Required fixes to keep the build clean after deduplication: - @appland/client: bump @types/node ^17 → ^18 (old types lacked AbortSignal static methods, conflicting with DOM lib), - @appland/scanner: bump lru-cache ^6 → ^10 (drop @types/lru-cache, update to named import, tighten cache value type to NonNullable), - fix two prettier formatting errors surfaced by updated package types.
dividedmind
force-pushed
the
chore/dedupe
branch
from
0ce3f48 to
f5d837c
Compare
All four affected major versions updated to patched releases via yarn up -R: - 3.1.2 → 3.1.5, - 5.1.6 → 5.1.9 (floor bumped in cli and scanner), - 7.4.2 → 7.4.9, - 9.0.4 → 9.0.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required fixes to keep the build clean after deduplication:
Also, bump minimatch to fix a GHSA.