Passing edges when the type is custom#53
Merged
Merged
Conversation
The custom-edge-passing PR carried a full dist/ rebuild. Per repo convention the committed bundle is regenerated at merge/resync, so revert dist to dev and keep the PR to its source change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0162MtGveF5YPNaEitFaowKM
…alization - Type the custom generator's sourcePosition/targetPosition as the 'top'|'right'|'bottom'|'left' cardinal union (matching getEdgePath's internal signature) instead of the looser `string`. - Add a test proving per-edge route data on edge.data survives a JSON round-trip (as toObject()/fromObject() do) and drives the generated path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0162MtGveF5YPNaEitFaowKM
Member
|
Thanks for this, @ronnorthrip — this is a nice catch. You correctly identified that forcing per-edge routing through a closure meant it couldn't survive I've merged it with a few maintainer touch-ups on top of your commit:
Full suite green (2919 tests) and typecheck clean. Appreciate the report and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing edges when the type is custom