dev tooling: uv + Makefile + tighter CI, secret-redacted repr#1
Merged
Conversation
anassg-lago
requested changes
May 18, 2026
anassg-lago
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv(lockfile committed for reproducible installs)Makefilewith 6 targets (sync,test,lint,format,check,clean)ruff format --checkand gates coverage at 80%api_keyinLagoConfig.__repr__/LagoClient.__repr__so logs/Sentry/print()can't leak itChanges
Tooling
uv.lock,.python-version(3.11) committed; CI usesastral-sh/setup-uv@v4with cachepyproject.toml:pytest-cov>=5added todevextrasMakefilewraps the common commands;make checkis CI parityCONTRIBUTING.mdrewritten around theuv+makeflowCI (
.github/workflows/ci.yml)ruff format --checkis now a gate (was missing —CONTRIBUTING.mdtold contributors to run it but CI didn't enforce)pytest --cov-fail-under=80(baseline measured at 81.5%; bump after backfilling repr tests)coverage.xmlartifact on the 3.12/ubuntu cellCode
LagoConfig.__repr__masksapi_keyas***xxxx(last 4 chars only);field(repr=False)on the attribute as defence-in-depthLagoClient.__repr__masks the same wayOne-time format pass
ruff format. All cosmetic — no logic changes. Necessary so the newruff format --checkgate passes on day 1.Test plan
make lintpasses locally (ruff check / format / mypy)make test— 237 passed, coverage 81.53% (above the 80% floor)Follow-ups (not in this PR)
lago_client.pyis 46% — the unit suite mocksEventQueue.senderdirectly, soLagoClient.send_batchis exercised only by integration tests. New__repr__adds to the gap; small dedicated test would close it and let us raise the coverage floor.