Remove unavailable server UI#8888
Open
atavism wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR removes reachability-warning strings, icons, and dialog flow from VPN location selection. Location settings now show only the protocol subtitle, and server selection proceeds directly to connecting after the existing macOS extension check. ChangesVPN warning removal
Sequence Diagram(s)sequenceDiagram
participant ServerLocationListView
participant onServerSelected
participant _connectToServer
ServerLocationListView->>onServerSelected: submit selected server
onServerSelected->>onServerSelected: check macOS extension permission
onServerSelected->>_connectToServer: connect directly
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the “unavailable/may be unreachable” server reachability UI and associated flow from the VPN location selection experience, simplifying the server list presentation and related localization/assets.
Changes:
- Removed reachability warning indicators (icons/tooltips) from server list tiles.
- Removed the “currently unavailable” section split and the manual-selection warning dialog flow.
- Deleted the reachability warning icon widget and removed related localization strings/exports.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/features/vpn/single_city_server_view.dart | Removes reachability warning parameter and trailing warning icon from single-city server tiles. |
| lib/features/vpn/server_selection.dart | Simplifies server list sections and removes unreachable-server warning UI/flow. |
| lib/features/vpn/location_setting.dart | Removes “may be unreachable” subtitle/icon behavior from the location setting tile. |
| lib/core/widgets/server_reachability_warning_icon.dart | Deletes the now-unused warning icon widget. |
| lib/core/common/common.dart | Removes export for the deleted warning icon widget. |
| assets/locales/en.po | Removes now-unused reachability/unavailable-related English strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
15
| final bool isSelected; | ||
| final bool nested; | ||
|
|
||
| /// Whether to surface the "may be unreachable" warning icon. Disabled for | ||
| /// free users, who see every location without the reachability distinction. | ||
| final bool showReachabilityWarning; | ||
|
|
||
| const SingleCityServerView({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit