Skip to content

feat: using latest water with shared runtime#535

Open
WendelHime wants to merge 4 commits into
mainfrom
feat/using-latest-water-changes
Open

feat: using latest water with shared runtime#535
WendelHime wants to merge 4 commits into
mainfrom
feat/using-latest-water-changes

Conversation

@WendelHime

@WendelHime WendelHime commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR updates the water reference for using the latest water fork version and updates the lantern-box version for using the latest version that supports the water shared runtime

Summary by CodeRabbit

  • Chores
    • Updated a couple of bundled dependencies to newer versions.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 026df69e-ea9e-4ce6-b025-c3a7cb3217f5

📥 Commits

Reviewing files that changed from the base of the PR and between a8b1916 and cff6dc5.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

This change updates go.mod by modifying the replace directive for the water package to a newer pseudo-version, and bumping the lantern-box dependency version from v0.0.95 to v0.0.98.

Changes

Dependency Updates

Layer / File(s) Summary
go.mod dependency version bumps
go.mod
Updated the replace directive for github.com/refraction-networking/water to a newer github.com/getlantern/water pseudo-version, and bumped github.com/getlantern/lantern-box from v0.0.95 to v0.0.98.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop, a skip, two lines anew,
go.mod refreshed with versions true.
Water flows to v-newer ground,
lantern-box hops, ninety-eight found.
🐇 Carrots safe, dependencies sound!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading the water dependency to a newer shared-runtime version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/using-latest-water-changes

Comment @coderabbitai help to get the list of available commands.

@WendelHime WendelHime marked this pull request as ready for review June 30, 2026 20:12
Copilot AI review requested due to automatic review settings June 30, 2026 20:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Radiance’s Go module dependencies to use newer Lantern-provided builds of water (via a replace pin) and lantern-box, aligning with the PR goal of “latest water with shared runtime”.

Changes:

  • Bump github.com/getlantern/lantern-box from v0.0.95 to v0.0.98.
  • Update the replace github.com/refraction-networking/water => github.com/getlantern/water pin to v0.7.1-alpha.0.20260619150927-31d1e50fe910.
  • Refresh go.sum to match the updated module graph.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates the water replace pin and bumps lantern-box to v0.0.98.
go.sum Updates module checksums to reflect the new lantern-box and water versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@WendelHime WendelHime requested a review from garmr-ulfr June 30, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants