Skip to content

Fix simulator session argument overrides - #512

Draft
vsolano9 wants to merge 1 commit into
getsentry:mainfrom
vsolano9:codex/fix-509-simulator-argument-precedence
Draft

Fix simulator session argument overrides#512
vsolano9 wants to merge 1 commit into
getsentry:mainfrom
vsolano9:codex/fix-509-simulator-argument-precedence

Conversation

@vsolano9

Copy link
Copy Markdown
Contributor

What changed

  • expose session-backed simulator build, build-and-run, and test inputs in the MCP schemas so explicit call arguments can override stored defaults
  • add typed onlyTesting and skipTesting inputs to test_sim
  • cover the MCP boundary with end-to-end regression tests and refresh the public schema fixtures

Root cause

The session-aware handler already merged explicit arguments after defaults, but the public simulator schemas omitted every default-backed field. MCP validation therefore removed explicit project, scheme, destination, and configuration values before they reached that merge.

Validation

  • npm run format:check
  • npm run lint (0 errors; existing warnings only)
  • npm run typecheck
  • npm run build
  • npm run test:smoke (123 passed)
  • npm run test:schema-fixtures (333 passed)
  • focused simulator tests (52 passed)
  • MCP session end-to-end tests (9 passed)

The full npm test run passed 2,588 of 2,591 tests. Three unrelated baseline tests failed in config-store.test.ts and purge-ui.test.ts; none exercise files changed here.

Fixes #509.

AI assistance: Codex helped reproduce the MCP schema boundary failure, implement the fix, and run validation. The resulting diff and test output were reviewed before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Simulator tools silently ignore explicit arguments when session defaults are set

1 participant