ref(chat): Persist location configuration in SQL - #1357
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Store user configuration under destinationKey instead of bare channelId so Slack and future providers share one durable identity. Keep a one-time Redis channel-state cutover for live Slack records. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
Key configuration by the canonical Location row instead of a serialized Destination. Resolve or create the provider Location before reading or writing configuration. Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
…tion-sql # Conflicts: # packages/junior/src/chat/runtime/turn-preparation.ts Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
August 9, 2026 21:48
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ea5bdbd. Configure here.
Insert Redis cutover rows only when SQL is still empty, then re-read so a concurrent set wins.
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move user-authored configuration off expiring Redis scratch into durable SQL, scoped to a provider Location.
Ownership
junior_location_configurations.location_idreferences the canonical Location row injunior_destinations(location_id, key)has one row with a text valueLocation/locationCutover
#1267/v0.147.0removal markerChecks
This follows the Source / Location / Destination split in #1200 and does not overlap the reply-delivery changes in #1238.
Refs #1267