fix(codeowners): Double star pattern incorrectly matches on suffixes #5508
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvxluo
changed the title
Dav1dde
approved these changes
Jan 5, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cvxluo
force-pushed
the
cvxluo/double-star-code-owners-matching
branch
from
8fd73d5 to
5bb4b11
Compare
Member
|
@cvxluo Looks like integration tests broke because the playstation tests use a hardcoded timestamp which is now no longer valid. Will fix this on Wednesday, sorry for the inconvenience. |
Contributor
Author
no problem, thanks for letting me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://linear.app/getsentry/issue/ID-1128/codeowners-seems-to-be-substring-matching-instead-of-exact-filename
Codeowners with
**/<filename>would match onexample/prefix_<filename>. Add a new regex case to handle**/patterns correctly.