ref(outcomes): Transport outcomes as metrics#6082
Open
Dav1dde wants to merge 1 commit into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/as-outcomes-is-as-metrics
branch
from
11ebf25 to
0b7fd38
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/as-outcomes-is-as-metrics
branch
3 times, most recently
from
c269bfd to
682bf1a
Compare
Dav1dde
force-pushed
the
dav1d/as-outcomes-is-as-metrics
branch
2 times, most recently
from
ad440c0 to
6052185
Compare
Dav1dde
force-pushed
the
dav1d/as-outcomes-is-as-metrics
branch
from
6052185 to
76fcbe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treats
AsOutcomeslikeAsMetricsand removes the temporaryAsMetricsagain. Client reports are still unaffected and need to be implemented in another PR. After client reports are implemented the outcome aggregator service no longer needs to aggregate.Functional change: Unknown projects no longer write outcomes to that project id, which I'd consider as a bugfix. If the project doesn't exist, there doesn't need to be an outcome for it (some tests are adjusted here and/or deleted).
Some changes to tests: Since there is no dedicated outcomes endpoint anymore, outcomes are extracted from global metrics as well as metric bucket envelope items. Outcomes now have always a key id, org and project id as they are resolved with a project config.
Important: Rollout in environments with multiple internal Relays must happen from the first Relay->Processing Relay