perf(instrumentation): [Generated metadata 2] Generate manifest metadata - #1405
Merged
Conversation
This was referenced Aug 14, 2026
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
2 times, most recently
from
August 17, 2026 08:36
45fffeb to
d6e0617
Compare
romtsn
force-pushed
the
perf/generated-sdk-metadata-availability
branch
from
August 17, 2026 08:50
5b50fc6 to
01c33f8
Compare
romtsn
marked this pull request as ready for review
August 17, 2026 09:09
romtsn
requested review from
0xadam-brown,
adinauer,
markushi and
runningcode
as code owners
August 17, 2026 09:09
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
from
August 17, 2026 09:12
d6e0617 to
ca575d9
Compare
romtsn
force-pushed
the
perf/generated-sdk-metadata-availability
branch
from
August 17, 2026 09:57
01c33f8 to
d6cc1ee
Compare
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
from
August 17, 2026 10:01
ca575d9 to
a819c4f
Compare
runningcode
reviewed
Aug 17, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
looks great! main concern is the separate of responsibilities. and we should also add a configuration cache test for this!
| } | ||
| .toSet() | ||
| val availability = resolveClassAvailability(modules) | ||
| val metadata = ManifestMetadataParser.parse(mergedManifest.get().asFile) |
Contributor
There was a problem hiding this comment.
if I understand the architecture correctly it seems like we have 3/4 concerns that i would separate this in to 3 tasks. this improves the cacheability and separates responsibilities:
- resolving the class availability
2 parsing the manifest
3 merging the two / generating the source file
Member
Author
There was a problem hiding this comment.
hm, I'm thinking if an intermediate file I/O and task scheduling that we would introduce by splitting this up would cost more than the work avoided by cacheability? It's map lookup + XML parsing which I guess should be rather quick?
8 tasks
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
from
August 19, 2026 12:31
a819c4f to
1f5ce9f
Compare
Member
Author
thanks for the review - this one has been addressed in #1404 and should cover this too :) |
romtsn
force-pushed
the
perf/generated-sdk-metadata-availability
branch
from
August 24, 2026 13:00
a965436 to
e193d84
Compare
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
from
August 24, 2026 13:09
1f5ce9f to
b565999
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
runningcode
approved these changes
Aug 24, 2026
Base automatically changed from
perf/generated-sdk-metadata-availability
to
main
August 24, 2026 15:25
Read resolved Sentry metadata from the final merged manifest in the generated-source task. Keep the SDK transform parameterless by emitting a stable call to the app-owned generated class, with PackageManager fallback for unresolved resources. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Inject generated manifest metadata directly into ManifestMetadataReader while retaining structural compatibility checks. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Describe the initialization improvement without citing benchmark-specific percentages. Co-Authored-By: Codex <noreply@openai.com>
romtsn
force-pushed
the
perf/generated-sdk-metadata-manifest
branch
from
August 25, 2026 08:55
b565999 to
f66bc28
Compare
Cache class availability and parsed manifest metadata independently so changes to either input avoid repeating unrelated work. Co-Authored-By: Codex <noreply@openai.com>
Keep the build-time option tasks together under an optimization package as their responsibilities expand. Co-Authored-By: Codex <noreply@openai.com>
Place generated sources and intermediate files below build/sentry so AGP-owned output directories remain separate. Co-Authored-By: Codex <noreply@openai.com>
Allow the first configuration-cache test build to restore the cacheable generator task from the shared TestKit build cache. Keep requiring the second build to be up to date. Co-Authored-By: OpenAI Codex <noreply@openai.com>
runningcode
reviewed
Aug 25, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
left some comments below
Remove redundant directory creation from tasks whose complete output file paths are declared to Gradle. Co-Authored-By: OpenAI Codex <noreply@openai.com>
runningcode
approved these changes
Aug 25, 2026
Report build-time manifest metadata inference failures through the opt-out-aware telemetry service while preserving the runtime fallback. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate typed Sentry metadata from each variant final merged manifest in the app-owned build-time options class.
The SDK ASM transform remains parameterless and emits only a stable symbolic call. Resource-backed or otherwise unresolved values return null so the SDK retains its PackageManager fallback. The matching SDK consumer is getsentry/sentry-java#5969.