fix(snapshots): Show clear error when project slug was renamed#3341
Merged
Conversation
233af6f to
eda6057
Compare
NicoHinderling
commented
Jun 22, 2026
szokeasaurusrex
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snapshots uploadagainst a renamed project slug failed withcould not parse JSON response: missing field 'objectstore'. On a rename the API returns a302whose body the snapshot calls deserialized as their response type, bypassingconvert_rnf— the helper every other project-scoped endpoint uses to surface renames.This routes both snapshot calls through
convert_rnf, which now reads the new slug from the top-levelslugfield the server actually sends (it previously read a non-existentdetail.slug, leaving the rename message dead for allProjectNotFoundcallers). Users now get the existing clearproject was renamed to '<slug>'error.Scope is project renames only; org renames (404) and the same latent failure on
events list/issuescommands are out of scope.Fixes #3337