feat(data-collection)!: Filter URL query params#8414
Open
philprime wants to merge 9 commits into
Open
Conversation
Contributor
|
philprime
force-pushed
the
feat/query-parameter-filtering
branch
from
July 15, 2026 06:14
0ec4307 to
fae6e30
Compare
philprime
commented
Jul 15, 2026
philprime
force-pushed
the
feat/query-parameter-filtering
branch
from
July 16, 2026 11:26
fae6e30 to
8a1fb04
Compare
philprime
changed the base branch from
main
to
philprime/data-collection/top-level-option
July 16, 2026 11:30
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ddbec00 | 1229.12 ms | 1261.33 ms | 32.20 ms |
| c1c9578 | 1219.32 ms | 1261.74 ms | 42.43 ms |
| f213b0b | 1220.62 ms | 1251.59 ms | 30.97 ms |
| d98d6a8 | 1219.69 ms | 1255.85 ms | 36.16 ms |
| 71859d3 | 1209.83 ms | 1241.65 ms | 31.83 ms |
| 5e4d0a6 | 1230.40 ms | 1255.44 ms | 25.04 ms |
| 44b7b59 | 1211.91 ms | 1248.90 ms | 36.99 ms |
| 151b3ee | 1238.69 ms | 1270.73 ms | 32.05 ms |
| 4014441 | 1232.16 ms | 1266.41 ms | 34.25 ms |
| b95fd1b | 1226.73 ms | 1260.77 ms | 34.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ddbec00 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| c1c9578 | 24.14 KiB | 1.20 MiB | 1.18 MiB |
| f213b0b | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| d98d6a8 | 24.14 KiB | 1.23 MiB | 1.20 MiB |
| 71859d3 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 5e4d0a6 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 44b7b59 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 151b3ee | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 4014441 | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| b95fd1b | 24.14 KiB | 1.17 MiB | 1.15 MiB |
Previous results on branch: feat/query-parameter-filtering
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 89136d8 | 1234.49 ms | 1263.34 ms | 28.85 ms |
| 05ec8aa | 1224.61 ms | 1255.90 ms | 31.29 ms |
| 44e68c7 | 1220.22 ms | 1260.73 ms | 40.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 89136d8 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 05ec8aa | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 44e68c7 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
philprime
force-pushed
the
philprime/data-collection/top-level-option
branch
from
July 16, 2026 12:18
94f5ff5 to
313e8d8
Compare
philprime
force-pushed
the
feat/query-parameter-filtering
branch
from
July 16, 2026 12:21
8a1fb04 to
dba1b18
Compare
philprime
marked this pull request as ready for review
July 16, 2026 12:21
philprime
requested review from
a team,
NinjaLikesCheez,
itaybre,
noahsmartin and
philipphofmann
as code owners
July 16, 2026 12:21
Base automatically changed from
philprime/data-collection/top-level-option
to
main
July 16, 2026 12:56
Filter automatic network query parameters in V10 spans, breadcrumbs, and failed-request events. Preserve legacy URL behavior outside V10 while exposing the renamed data collection options. Fixes #8249
philprime
force-pushed
the
feat/query-parameter-filtering
branch
from
July 16, 2026 13:01
64f0326 to
14a8ae4
Compare
Always apply the configured URL query parameter behavior when bridging options to Objective-C. Fixes #8249
philprime
enabled auto-merge (squash)
July 16, 2026 13:11
The V10 docs-sync test treats the private Objective-C bridge as a public option. Exempt it from user-facing documentation checks.
NinjaLikesCheez
approved these changes
Jul 17, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7892013. Configure here.
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📜 Description
Rename the V10 data-collection options to distinguish URL and database query
parameters, then apply
urlQueryParamsfiltering to automatic network spans,breadcrumbs, Session Replay breadcrumb payloads, and failed-request events.
V10 URL fields retain a filtered query string while span descriptions use the
query-free base URL. The legacy SDK retains its existing query-free URL
behavior.
💡 Motivation and Context
The data-collection specification requires URL query filtering wherever an
automatically collected query string is emitted. This makes the V10 network
telemetry consistent with its key-value deny-list, allow-list, and off modes.
This is a V10-breaking option rename:
dataCollection.queryParams→dataCollection.urlQueryParamsdataCollection.database.queryParams→dataCollection.database.urlQueryParamsFixes #8249
💚 How did you test it?
make formatmake analyzemake build-iosmake build-ios-v10make test-ios ONLY_TESTING=SentryTests/UrlSanitizedTests,SentryTests/SentryNetworkTrackerTests,SentryTests/SentryDataCollectionOptionsTests,SentryTests/SentryDatabaseCollectionOptionsTestsmake test-ios-v10 ONLY_TESTING=SentryTests/UrlSanitizedTests,SentryTests/SentryNetworkTrackerTests,SentryTests/SentryDataCollectionOptionsTests,SentryTests/SentryDatabaseCollectionOptionsTestsmake generate-public-api📝 Checklist
sendDefaultPIIis enabled.#skip-changelog