feat(android): [Unhandled Sessions 4] Add session update for dropped hybrid errors by buenaflor · Pull Request #5990 · getsentry/sentry-java

buenaflor · 2026-08-25T10:43:45Z

PR Stack (Unhandled Sessions)

feat(core): Unhandled Sessions #5915 (collection)
feat(core): [Unhandled Sessions 1] Add Unhandled session state and non-terminating error flag #5919
fix(core): [Unhandled Sessions 2] Don't let a queued SessionStart overwrite a newer session #5920
feat(android): [Unhandled Sessions 3] Add internal non-terminating envelope capture #5921
feat(android): [Unhandled Sessions 4] Add session update for dropped hybrid errors #5990

📜 Description

Adds InternalSentrySdk.updateSessionForDroppedEventNonTerminating(boolean crashed) so hybrid SDKs can apply the same session side effects as captureEnvelopeNonTerminating when an error is dropped by sampling.

It delegates to the private updateSessionNonTerminating helper extracted in #5921.

crashed=true records a non-terminating unhandled error (same session id, stay Ok, persist)
crashed=false increments the error count without the unhandled flag
no envelope is sent
endSession still finalizes as unhandled

💡 Motivation and Context

Hybrid SDKs sample in Dart/JS before calling into Java. Unsampled errors never reach captureEnvelopeNonTerminating, so the session is not updated. Native SentryClient updates the session before sampling; this API closes that gap for the non-terminating hybrid path.

Do not call this for events dropped by beforeSend or ignored exception types.

💚 How did you test it?

New InternalSentrySdkTest coverage: an unhandled dropped error flags and persists the session without sending an envelope; a handled dropped error increments errors only; endSession afterwards finalizes as unhandled.

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Update the Flutter Android bridge to call this when an error is dropped by sampling, instead of skipping the native session update.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Hybrid SDKs skip captureEnvelopeNonTerminating when an error is unsampled, so the session never records it. Expose the same non-terminating session update without sending the event. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-25T10:44:06Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-25T10:44:19Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b866f15

github-actions · 2026-08-25T10:44:38Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

sentry · 2026-08-25T10:47:34Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.53.0 (1)	release

⚙️ sentry-android Build Distribution Settings

…nt PR Leave the stack's capture methods as they are and add the dropped-event API as a standalone method so this PR stays additive. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-25T10:54:20Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

…ed-sessions-dropped-event Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-25T10:59:32Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

github-actions · 2026-08-25T11:08:04Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	317.48 ms	377.81 ms	60.33 ms
Size	0 B	0 B	0 B

Baseline results on branch: feat/unhandled-sessions-internal-api

Startup times

Revision	Plain	With Sentry	Diff
`2807f64`	306.53 ms	357.96 ms	51.43 ms

App size

Revision	Plain	With Sentry	Diff
`2807f64`	0 B	0 B	0 B

Previous results on branch: feat/unhandled-sessions-dropped-event

Startup times

Revision	Plain	With Sentry	Diff
`ae3c2c6`	305.84 ms	363.12 ms	57.28 ms

App size

Revision	Plain	With Sentry	Diff
`ae3c2c6`	0 B	0 B	0 B

This path is for hybrid errors dropped by sample rate, not rate limiting. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-08-25T12:30:25Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

…ed-sessions-dropped-event

github-actions · 2026-08-25T12:41:30Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

Copilot

Pull request overview

Adds an internal Android API for updating sessions when hybrid errors are dropped by sampling.

Changes:

Adds dropped-event session update handling.
Adds tests for handled and unhandled dropped errors.
Updates API metadata and changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Summary
`sentry-android-core/src/test/java/io/sentry/android/core/InternalSentrySdkTest.kt`	Adds coverage for dropped-error session behavior and finalization.
`sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java`	Adds the session-update API. Moderate issue remains: terminal sessions should be guarded before updates. (2 votes)
`sentry-android-core/api/sentry-android-core.api`	Records the new API surface.
`CHANGELOG.md`	Documents the API addition. Nit: align the changelog entry with the PR checklist policy. (4 votes)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

changelog

4968ac9

Co-authored-by: Cursor <cursoragent@cursor.com>

ref(android): Keep captureEnvelope paths unchanged in the dropped-eve…

09097b7

…nt PR Leave the stack's capture methods as they are and add the dropped-event API as a standalone method so this PR stays additive. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'feat/unhandled-sessions-internal-api' into feat/unhandl…

e762195

…ed-sessions-dropped-event Co-authored-by: Cursor <cursoragent@cursor.com>

docs(android): Mention only sampling for the dropped-event session API

b518655

This path is for hybrid errors dropped by sample rate, not rate limiting. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'feat/unhandled-sessions-internal-api' into feat/unhandl…

b866f15

…ed-sessions-dropped-event

buenaflor marked this pull request as ready for review August 25, 2026 13:02

Copilot AI lite review requested due to automatic review settings August 25, 2026 13:02

buenaflor requested review from 0xadam-brown, adinauer, markushi, romtsn and runningcode as code owners August 25, 2026 13:02

Copilot started reviewing on behalf of buenaflor August 25, 2026 13:03 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

Comment thread CHANGELOG.md

Comment thread sentry-android-core/src/main/java/io/sentry/android/core/InternalSentrySdk.java

Uh oh!

Uh oh!

Conversation

buenaflor commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Stack (Unhandled Sessions)

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

sentry Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: feat/unhandled-sessions-internal-api

Startup times

App size

Previous results on branch: feat/unhandled-sessions-dropped-event

Startup times

App size

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Aug 25, 2026

🚨 Detected changes in high risk code 🚨

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

buenaflor commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

sentry Bot commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading