feat(core): Send gen_ai spans as v2 envelope items#20342
Draft
andreiborza wants to merge 19 commits intodevelopfrom
Draft
feat(core): Send gen_ai spans as v2 envelope items#20342andreiborza wants to merge 19 commits intodevelopfrom
andreiborza wants to merge 19 commits intodevelopfrom
Conversation
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
from
e02cd9b to
d0cb9d0
Compare
mydea
reviewed
Apr 16, 2026
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: span.origin, | ||
| }); | ||
|
|
||
| // Enrich from transaction event context (same pattern as captureSpan.ts applyCommonSpanAttributes) |
Member
There was a problem hiding this comment.
let's not do this, keep it simple for the time being!
Contributor
size-limit report 📦
|
Lms24
reviewed
Apr 16, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Generally LGTM. Agree with Francesco that we should only iterate over spans if we know that >0 ai spans are in the event. Left some more comments.
Regarding bundle size: I think this is fair to keep in core, especially if we manage to cut down on the common attribute application.
| return streamedSpanJsonToSerializedSpan(streamedSpan); | ||
| } | ||
|
|
||
| function mapV1StatusToV2(status: string | undefined): 'ok' | 'error' { |
Member
There was a problem hiding this comment.
l: we could make this slightly more size-efficient with an inlined ternary instead of the function. But feel free to disregard.
Member
Author
There was a problem hiding this comment.
Yep, inlined it. Thanks!
Comment on lines
+50
to
+69
| const sdk = client.getSdkMetadata(); | ||
| const { release, environment, sendDefaultPii } = client.getOptions(); | ||
|
|
||
| safeSetSpanJSONAttributes(streamedSpan, { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_RELEASE]: transactionEvent.release || release, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ENVIRONMENT]: transactionEvent.environment || environment, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SEGMENT_NAME]: transactionEvent.transaction, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SEGMENT_ID]: transactionEvent.contexts?.trace?.span_id, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SDK_NAME]: sdk?.sdk?.name, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SDK_VERSION]: sdk?.sdk?.version, | ||
| ...(sendDefaultPii | ||
| ? { | ||
| [SEMANTIC_ATTRIBUTE_USER_ID]: transactionEvent.user?.id, | ||
| [SEMANTIC_ATTRIBUTE_USER_EMAIL]: transactionEvent.user?.email, | ||
| [SEMANTIC_ATTRIBUTE_USER_IP_ADDRESS]: transactionEvent.user?.ip_address, | ||
| [SEMANTIC_ATTRIBUTE_USER_USERNAME]: transactionEvent.user?.username, | ||
| } | ||
| : {}), | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
m: I don't think we need any of the common span attribute application logic, correct? We just map whatever is on the gen_ai span to a v2 span. Should save a decent amount of bytes.
Member
Author
There was a problem hiding this comment.
Right, removed. Thanks!
Comment on lines
+43
to
+47
| // Fold op and origin into attributes | ||
| safeSetSpanJSONAttributes(streamedSpan, { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: span.op, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: span.origin, | ||
| }); |
Member
There was a problem hiding this comment.
l: do we need this? Shouldn't the op -> sentry.op backfill have happened already? logaf-l though as only minimal hit and we're already defensive.
Member
Author
There was a problem hiding this comment.
Nope, removed. Thanks!
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
2 times, most recently
from
b8c8b65 to
d153251
Compare
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
from
d153251 to
69b5cf8
Compare
…nsactions to lessen the extraction performance impact
mydea
reviewed
Apr 16, 2026
|
|
||
| for (const span of event.spans) { | ||
| if (span.op?.startsWith('gen_ai.')) { | ||
| genAiSpans.push(span); |
Member
There was a problem hiding this comment.
l: not quite sure, but maybe we can just use splice here instead of creating a new array?
Member
Author
There was a problem hiding this comment.
Splicing becomes awkward, you'd have to backward splice, or do some pre-collecting of indices iteration... not much gain there.
If we splice backwards, we'd need to reverse gen_ai spans array, I think the code complexity and minimal performance gain from that (still have to reverse) is not worth it.
If we can send the ai spans in reverse order, we'd save some time but that's bound to create some confusion.
Member
Author
There was a problem hiding this comment.
I at least got rid of the extra .map
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
2 times, most recently
from
d2e8767 to
9e6b1bb
Compare
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
2 times, most recently
from
ac09aa4 to
a27a074
Compare
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
2 times, most recently
from
08a995b to
c5b22d8
Compare
…ion compat The v2 span attribute serializer currently drops array values. Stringifying arrays in processEndedVercelAiSpan keeps attributes like gen_ai.response.finish_reasons intact when the span is serialized to the v2 format. Can be removed once span streaming supports arrays natively. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
3 times, most recently
from
1939010 to
e93d819
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/gen-ai-span-v2-poc
branch
from
e93d819 to
76d835c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76d835c. Configure here.
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proof of concept to send
gen_ai.*spans as span v2 envelope items alongside the legacy transaction, so they're processed by Sentry's new span ingestion pipeline. This only applies in non-span streaming mode.It pulls all
gen_aispans out of the event , converts them to span v2 spans and attaches a span v2 container to the envelope.