Skip to content

fix(core): route replay events in multiplexed transport #20408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logaretm wants to merge 2 commits into
base: develop
Choose a base branch
from
+35 −4
Open

fix(core): route replay events in multiplexed transport #20408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b04cc
fix(core): route replay events in multiplexed transport
logaretm Apr 20, 2026
3bf438e
chore: bump CDN bundle size limits
logaretm Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .size-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ module.exports = [
name: 'CDN Bundle (incl. Tracing, Replay, Logs, Metrics)',
path: createCDNPath('bundle.tracing.replay.logs.metrics.min.js'),
gzip: true,
limit: '83 KB',
limit: '84 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay, Feedback)',
Expand Down Expand Up @@ -283,7 +283,7 @@ module.exports = [
path: createCDNPath('bundle.tracing.replay.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '255 KB',
limit: '256 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed',
Expand All @@ -297,7 +297,7 @@ module.exports = [
path: createCDNPath('bundle.tracing.replay.feedback.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '268 KB',
limit: '269 KB',
},
// Next.js SDK (ESM)
{
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/transports/multiplexed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export function makeMultiplexedTransport<TO extends BaseTransportOptions>(
const actualMatcher: Matcher =
matcher ||
(args => {
const event = args.getEvent();
const event = args.getEvent(['event', 'replay_event']);
if (
event?.extra?.[MULTIPLEXED_TRANSPORT_EXTRA_KEY] &&
Array.isArray(event.extra[MULTIPLEXED_TRANSPORT_EXTRA_KEY])
Expand Down
31 changes: 31 additions & 0 deletions packages/core/test/lib/transports/multiplexed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const TRANSACTION_ENVELOPE = createEnvelope<EventEnvelope>(
{ event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2', sent_at: '123' },
[[{ type: 'transaction' }, TRANSACTION_EVENT] as EventItem],
);
const REPLAY_EVENT = { type: 'replay_event', event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2' };

const DEFAULT_DISCARDED_EVENTS: ClientReport['discarded_events'] = [
{
Expand Down Expand Up @@ -320,4 +321,34 @@ describe('makeMultiplexedTransport() with default matcher', () => {
const transport = makeTransport({ url: DSN1_URL, ...transportOptions });
await transport.send(envelope);
});

it('sends replay events to targets provided in event.extra[MULTIPLEXED_TRANSPORT_EXTRA_KEY]', async () => {
expect.assertions(2);

const makeTransport = makeMultiplexedTransport(
createTestTransport(
url => {
expect(url).toBe(DSN1_URL);
},
url => {
expect(url).toBe(DSN2_URL);
},
),
);

const envelope = createEnvelope<EventEnvelope>({ event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2', sent_at: '123' }, [
[
{ type: 'replay_event' },
{
...REPLAY_EVENT,
extra: {
[MULTIPLEXED_TRANSPORT_EXTRA_KEY]: [DSN1, DSN2],
},
},
] as EventItem,
]);
Comment on lines +339 to +349
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test creates a replay_event envelope item but asserts it as EventEnvelope / EventItem. Using the wrong envelope/item types in tests can hide real shape differences for replay envelopes. Consider typing the envelope/item as a generic Envelope/EnvelopeItem (or ReplayEnvelope if you include the full replay envelope structure) instead of asserting EventItem.

Copilot uses AI. Check for mistakes.

const transport = makeTransport({ url: DSN1_URL, ...transportOptions });
await transport.send(envelope);
});
});
Loading