chore(test): Reduce unneeded idleTimeout test config#20467
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9f4a7d0. Configure here.
| } | ||
|
|
||
| sentryTest('should capture a `connection.rtt` metric.', async ({ getLocalTestUrl, page }) => { | ||
| sentryTest('should capture a `connection.rtt` metric. xxx', async ({ getLocalTestUrl, page }) => { |
There was a problem hiding this comment.
Accidentally committed "xxx" debug marker in test name
Low Severity
The test name 'should capture a \connection.rtt` metric. xxx'has an extraneous xxx` suffix appended to it. This looks like a leftover debugging marker (possibly used to isolate/run a single test during development) that was accidentally included in the commit.
Reviewed by Cursor Bugbot for commit 9f4a7d0. Configure here.
logaretm
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking a bit at what the slowest browser-integration-tests are, I found an easy-to-fix pattern in our tests - we had a lot of tests there that set some arbitrary
idleTimeoutto thebrowserIntegrationTest. This massively made these tests slower as it takes much longer to flush any pageload span. Many test runtimes reduced from 10-20s to 1-5s due to this change. A few places remain where this seems to be necessary, but there are way fewer now.FYI 1000ms is the default, we also had some defining this for some reason, I also removed those to be more consistent.