test(tanstackstart-react): remove outdated start-plugin-core pin#20511
Draft
nicohrubec wants to merge 1 commit intodevelopfrom
Draft
test(tanstackstart-react): remove outdated start-plugin-core pin#20511nicohrubec wants to merge 1 commit intodevelopfrom
nicohrubec wants to merge 1 commit intodevelopfrom
Conversation
The pin to @tanstack/start-plugin-core@1.167.35 was added in #20482 to work around a broken 1.168.0 release. Since then, @tanstack/react-start 1.167.44+ moved to importing from `@tanstack/start-plugin-core/vite`, a subpath that only exists in 1.169.0+. The old pin now forces the broken-against-current-react-start version, so both regular CI and canary fail with `ERR_PACKAGE_PATH_NOT_EXPORTED: ./vite`. react-start now declares an exact `start-plugin-core: 1.169.3` dep, so removing the override lets pnpm resolve the matching version that actually exports `./vite`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nicohrubec
changed the title
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
look like we can unpin again