feat(core)!: Return StreamedSpanJSON from spanToJSON - #22968
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2327a59. Configure here.
`spanToJSON` now returns the intermediate `StreamedSpanJSON` representation instead of the legacy `SpanJSON`. The previous behaviour is still available as `spanToStaticSpanJSON`, and the old `spanToStreamedSpanJSON` export is gone (it *is* `spanToJSON` now). Field mapping for call sites: `description` -> `name`, `data` -> `attributes`, `timestamp` -> `end_timestamp`, and `op`/`origin` move into `attributes` under `sentry.op` / `sentry.origin`. `status` is narrowed to `'ok' | 'error'`. `end_timestamp` is optional on `StreamedSpanJSON` and only required on `SerializedStreamedSpan`, so the guarantee we actually care about — every span we *send* has an end timestamp — is enforced at the single serialization boundary (`streamedSpanJsonToSerializedSpan`) rather than baked into every span representation. That keeps `end_timestamp` usable as the "has this span ended?" signal it already was, so the open-span checks in `browserTracingIntegration`, `idleSpan` and the React Router instrumentation stay simple field reads.
Lms24
force-pushed
the
lms/ref-spanToJson
branch
from
August 7, 2026 16:20
9e8fed6 to
598470e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamedSpanJSONfromspanToJSON