docs(migration): Fix httpHeaders shape in dataCollection baseline - #23169
Open
andreiborza wants to merge 1 commit into
Open
docs(migration): Fix httpHeaders shape in dataCollection baseline#23169andreiborza wants to merge 1 commit into
httpHeaders shape in dataCollection baseline#23169andreiborza wants to merge 1 commit into
Conversation
`httpHeaders` takes `{ request, response }`, not a bare `CollectBehavior`.
The baseline example passed `{ deny: [...] }` directly, which matches
neither key, so both resolved to their `true` default and collected every
header instead of applying the denylist.
Apply the same fix to `docs/migration/v11-end-state.md`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
nicohrubec
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the
httpHeadersentry in the "keep the v10 default behavior" example, in bothMIGRATION.mdanddocs/migration/v11-end-state.md.Closes: #23168
Why
httpHeaderstakes{ request, response }, not a bareCollectBehavior. A top-leveldenymatches neither key, soresolveDataCollectionOptionsfell back to thetruedefault for both and collected every header, the opposite of what the example promises. TypeScript users hit a compile error, but JavaScript configs failed silently while appearing to opt out.