Skip to content

test(node): Port envelope-header tests to span streaming - #24528

Merged
JPeer264 merged 1 commit into
getsentry:developfrom
ihsraham:test/node-envelope-headers-streaming-24140
Sep 24, 2026
Merged

JPeer264 merged 1 commit into
getsentry:developfrom
ihsraham:test/node-envelope-headers-streaming-24140

Conversation

@ihsraham

Copy link
Copy Markdown
Contributor

Port the seven tracing/envelope-header suites to default span streaming while preserving their error-header, sampling and route-name checks. Complete the incoming baggage fixture with the public key required by streamed trace headers.

Part of #24140.

These scenarios and the static-lifecycle checks pass locally on Node 20.19.5; build, lint and root tests also pass. The integration type check still reports five errors in untouched Anthropic, MySQL and baggage suites, identical on unchanged develop.

Co-Authored-By: GPT-6 <codex@openai.com>
@ihsraham
ihsraham marked this pull request as ready for review September 21, 2026 12:37
@ihsraham
ihsraham requested a review from a team as a code owner September 21, 2026 12:37
@ihsraham
ihsraham requested review from JPeer264 and isaacs and removed request for a team September 21, 2026 12:37
@github-actions

Copy link
Copy Markdown
Contributor

👋 @isaacs, @JPeer264 — Please review this PR when you get a chance!

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for contributing

@JPeer264
JPeer264 merged commit d0b4cca into getsentry:develop Sep 24, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants