Conversation
ihsraham
force-pushed
the
feat/vue-router-5-e2e
branch
from
September 23, 2026 11:10
bcdccdc to
7587de5
Compare
Co-Authored-By: OpenAI/ChatGPT <codex@openai.com>
ihsraham
force-pushed
the
feat/vue-router-5-e2e
branch
from
September 23, 2026 11:12
7587de5 to
2d9742b
Compare
Contributor
Author
ihsraham
marked this pull request as ready for review
September 24, 2026 04:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vue 3 E2E app's latest variant upgrades Vue but keeps Vue Router 4. Add a required Router 5 variant that prints the installed version and runs the existing assertions, while retaining Router 4 coverage. No SDK runtime changes.
After rebasing onto
7070bd6, Router 5.3.1 passed all 14 fixture tests against the freshly packed SDK. Router 4.6.4 passed 13/14 initially; the soft-navigation web-vitals test timed out, then passed three isolated reruns. Router 5 reports a Vite peer warning with the fixture's Vite 5.4.21, but type-checking and both builds passed.Local checks used Node 22.22.2 and reused monorepo dependencies. Repository-wide lint failed in unchanged files; the full monorepo build and test suite were not rerun. CI passed, including lint and all three required Vue E2E variants.
Fixes #24373