Conversation
Contributor
size-limit report 📦
|
JPeer264
added this pull request to stack #24613
September 23, 2026 06:14
JPeer264
force-pushed
the
jp/node-suites-runtime-switch
branch
3 times, most recently
from
September 23, 2026 08:27
1a1632c to
0156f20
Compare
JPeer264
removed this pull request from stack #24613
September 23, 2026 09:51
JPeer264
added this pull request to stack #24633
September 23, 2026 09:51
JPeer264
force-pushed
the
jp/node-suites-runtime-switch
branch
3 times, most recently
from
September 23, 2026 12:24
b1b40cb to
5ee62e2
Compare
The Node integration runner now reads a `RUNTIME` env var (`node`, `bun` or `deno`) and spawns the scenario with that binary. Node preload flags become `--preload` on Bun and Deno. Deno also gets an import map for the test helpers, CommonJS detection, and bare Node builtins, because the workspace symlinks put the SDK packages outside `node_modules`. The Bun and Deno integration packages select Node suites in their Vitest configs, so the same scenarios run on all 3 runtimes without copies. Bun runs them twice: with `@sentry/node`, and with `@sentry/node` mapped to `@sentry/bun` by a preload. Single tests that a runtime does not support use `test.skipIf` on `RUNTIME`. The runner also waits longer for a server port on Bun and Deno, which start the SDK more slowly than Node, and it follows `SIGTERM` with `SIGKILL`: on Deno a `SIGTERM` listener (the Vercel integration has one) keeps a scenario alive after its test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/node-suites-runtime-switch
branch
from
September 23, 2026 13:23
5ee62e2 to
a42772a
Compare
… Deno Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
marked this pull request as ready for review
September 23, 2026 14:39
JPeer264
requested review from
andreiborza,
isaacs and
mydea
and removed request for
a team
September 23, 2026 14:39
JPeer264
removed this pull request from stack #24633
September 23, 2026 16:19
JPeer264
added this pull request to stack #24670
September 23, 2026 16:19
JPeer264
removed this pull request from stack #24670
September 23, 2026 17:26
JPeer264
added this pull request to stack #24671
September 23, 2026 17:31
isaacs
approved these changes
Sep 23, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Some opportunities for a bit of polishing, this is great!
Member
|
Failing e2e test is not related, afaict. Restarted with 🤞 |
…n.ts Co-authored-by: isaacs <i@izs.me>
Co-authored-by: isaacs <i@izs.me>
… Deno Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun and Deno each had only a handful of integration suites, so most SDK behavior was only tested on Node. This lets the Bun and Deno integration packages run the Node suites themselves instead of copying them: the Node runner reads a
RUNTIMEenv var and maps Node's preload flags to the other runtime, and each runtime package selects Node suites in its Vitest config.Single tests that a runtime does not support are skipped with
test.skipIfonRUNTIMEinside the Node suite, so the reason sits next to the test. On Bun the suites run twice: with@sentry/node, which is what meta-framework SDKs use on Bun, and with@sentry/nodemapped to@sentry/bun.This PR opts in to only some node tests (more will follow in the stack). It also makes the runner robust enough for slower runtimes: a longer wait for the server port on Bun and Deno, and
SIGKILLafterSIGTERM, because on Deno aSIGTERMlistener keeps a scenario alive after its test.Part of #24052 and #23889.
🤖 Generated with Claude Code