Conversation
Member
Author
|
bugbot run |
s1gr1d
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 76d5f93. Configure here.
Contributor
size-limit report 📦
|
isaacs
approved these changes
Sep 23, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Nice! footgun disarmed, love it.
| /** | ||
| * No SDK path reads a joined header today, but `Headers.get('set-cookie')` and `xhr.getResponseHeader()` | ||
| * join repeated `Set-Cookie` headers with ", ". A "," only starts a new cookie when a "name=" follows | ||
| * before the next ";" or ",", so the "," in `Expires=Wed, 21 Oct 2026 07:28:00 GMT` does not split. |
Member
There was a problem hiding this comment.
Expires=Wed, 21 Oct 2026 07:28:00 GMT
Thanks, I hate it. 😅 (this is directed at http, xhr, and fetch, not you or this patch)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to this discussion: #24536 (comment)