fix(inproc): only the handling thread cleans up#1579
Merged
supervacuus merged 2 commits intomasterfrom Mar 14, 2026
Merged
Conversation
jpnurmi
approved these changes
Mar 14, 2026
Collaborator
jpnurmi
left a comment
jpnurmi
left a comment
There was a problem hiding this comment.
Verified - no hangs during 50x test runs. Thank you! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1578
The cleanup bypass of the CAS losers might have been a merge victim when I picked up the PR again in February; this was certainly the idea that only the winner cleans up.
Maybe let's stay somewhere at SDK 24-26 in #1572, merge this first, and then merge this change from master into your branch.
I think the basic idea behind the analysis is sound, even if the explanation around the mutex where the threads are stuck seems very handwavy. I think this is just a symptom, and the actual cause has more to do with how re-raising from within signal handlers is handled vs. what happens when a fresh signal from the kernel arrives.
However, if we are lucky, it loosens the contention enough for our process to terminate; in that case, we should see the behavior in the previously affected platform versions.