Skip to content

fix(cache): Preserve cached minidump refs #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 2 commits into from
May 12, 2026
Merged

fix(cache): Preserve cached minidump refs #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e503686
fix(cache): Preserve cached minidump refs
jpnurmi May 12, 2026
8d1c472
Update CHANGELOG.md
jpnurmi May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

- Native/Breakpad/Windows: fixed capturing abort(). ([#1708](https://github.com/getsentry/sentry-native/pull/1708))
- Native/Windows: capture fast-fail and stack buffer overrun crashes via WER. ([#1710](https://github.com/getsentry/sentry-native/pull/1710))
- Preserve cached minidump refs. ([#1715](https://github.com/getsentry/sentry-native/pull/1715))

## 0.14.0

Expand Down
6 changes: 5 additions & 1 deletion src/sentry_envelope.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,8 +1216,12 @@ write_minidump(const sentry_envelope_item_t *item, void *data)
{
const char *att_type = sentry_value_as_string(
sentry_value_get_by_key(item->headers, "attachment_type"));
const char *content_type = sentry_value_as_string(
sentry_value_get_by_key(item->headers, "content_type"));
if (!sentry__string_eq(att_type, "event.minidump") || !item->payload
|| item->payload_len == 0) {
|| item->payload_len == 0
|| (content_type
&& sentry__string_eq(content_type, SENTRY_ATTACHMENT_REF_MIME))) {
return false;
}

Expand Down
17 changes: 16 additions & 1 deletion tests/unit/test_envelopes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,6 @@ SENTRY_TEST(attachment_ref_copy)
sentry_path_t *cache_dir = sentry__path_join_str(db_path, "cache");
sentry_path_t *cached = sentry__path_join_str(
cache_dir, "c993afb6-b4ac-48a6-b61b-2558e601d65d.dmp");
sentry__path_free(cache_dir);
TEST_CHECK(sentry__path_is_file(cached));

// envelope carries an attachment-ref item with the expected headers
Expand All @@ -951,8 +950,24 @@ SENTRY_TEST(attachment_ref_copy)
"application/x-dmp", "event.minidump", strlen("minidump_data"),
"c993afb6-b4ac-48a6-b61b-2558e601d65d.dmp");

sentry_path_t *cached_envelope = sentry__path_join_str(
cache_dir, "c993afb6-b4ac-48a6-b61b-2558e601d65d.envelope");
sentry__path_remove(cached_envelope);

TEST_CHECK_INT_EQUAL(
sentry__envelope_write_to_cache(envelope, cache_dir), 0);
size_t cached_len = 0;
char *cached_payload = sentry__path_read_to_buffer(cached, &cached_len);
TEST_ASSERT(!!cached_payload);
TEST_CHECK_INT_EQUAL(cached_len, strlen("minidump_data"));
TEST_CHECK(memcmp(cached_payload, "minidump_data", cached_len) == 0);
sentry_free(cached_payload);

sentry_envelope_free(envelope);
sentry__path_remove(cached_envelope);
sentry__path_free(cached_envelope);
sentry__path_remove(cached);
sentry__path_free(cache_dir);
sentry__path_free(cached);
sentry__path_free(db_path);
sentry__attachment_free(attachment);
Expand Down
Loading