Skip to content

[1.0] ci: release archive version #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpnurmi wants to merge 1 commit into from
+7 −4
Open

[1.0] ci: release archive version #2105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ targets:
github:getsentry/sentry-native:
maven:io.sentry:sentry-native-ndk:
- name: gcs
includeNames: /^(sentry-native\.zip)$/
includeNames: /^sentry-native-\d+\.\d+\.\d+.*\.zip$/
bucket: sentry-sdk-assets
paths:
- path: /sentry-native/{{version}}/
Expand All @@ -32,4 +32,4 @@ targets:
batchType: android
bundleIdPrefix: sentry-native-ndk-
requireNames:
- /^sentry-native.zip$/
- /^sentry-native-\d+\.\d+\.\d+.*\.zip$/
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,10 @@ jobs:

- name: Create source archive
run: |
version=$(sed -nE 's/^#[[:space:]]*define[[:space:]]+SENTRY_SDK_VERSION[[:space:]]+"([^"]+)".*/\1/p' include/sentry.h)
test -n "$version"
rm -rf build .c* .e* .git* scripts Makefile external/breakpad/src/tools external/breakpad/src/processor
zip -r sentry-native.zip .
zip -r "sentry-native-$version.zip" .

- name: Build NDK artifacts
working-directory: ndk
Expand All @@ -595,6 +597,6 @@ jobs:
name: ${{ github.sha }}
if-no-files-found: error
path: |
sentry-native.zip
sentry-native-*.zip
Comment thread
cursor[bot] marked this conversation as resolved.
ndk/lib/build/distributions/*.zip
ndk/lib/build/intermediates/merged_native_libs/release/mergeReleaseNativeLibs/out/lib/*
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- macOS/Linux: shared libraries now use ABI-versioned filenames, such as `libsentry.1.dylib` or `libsentry.so.1` for 1.x. Windows, Android, and static libraries remain unchanged. ([#2103](https://github.com/getsentry/sentry-native/pull/2103))
- NOTE: Applications must package the real versioned library and its symlinks, including `libsentry.1.dylib` or `libsentry.so.1`, because they link to and load the ABI-versioned name.
- Release archives now include the SDK version in the filename, such as `sentry-native-1.0.0.zip`. ([#2105](https://github.com/getsentry/sentry-native/pull/2105))

## Unreleased

Expand Down
Loading