feat(clickhouse_driver): Add db.query.text to streamed query spans#6635
Open
ericapisani wants to merge 2 commits into
Open
feat(clickhouse_driver): Add db.query.text to streamed query spans#6635ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
When span streaming is enabled, include the query text as a span attribute in the db.query.text field. Update test assertions to verify the attribute is present. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 91401 passed | ⏭️ 6136 skipped | Total: 97537 | Pass Rate: 93.71% | Execution Time: 331m 35s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2403 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.90% 89.89% -0.01%
==========================================
Files 192 192 —
Lines 23763 23763 —
Branches 8206 8206 —
==========================================
+ Hits 21362 21360 -2
- Misses 2401 2403 +2
- Partials 1344 1346 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
db.query.textattribute to ClickHouse driver spans when spanstreaming is enabled. This brings ClickHouse driver spans in line with other
database integrations like asyncpg that already include query text in streamed
spans.
Fixes #6634
Fixes PY-2547