Skip to content

chore(django): Use iscoroutinefunction shim in patch_views() #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 2 commits into from
Aug 4, 2026
Merged

chore(django): Use iscoroutinefunction shim in patch_views() #7024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd05517
chore(django): Use iscoroutinefunction shim in patch_views
alexander-alderman-webb Aug 4, 2026
c18d8ca
use early returns
alexander-alderman-webb Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions sentry_sdk/integrations/django/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,7 @@
if TYPE_CHECKING:
from typing import Any


try:
from asyncio import iscoroutinefunction
except ImportError:
iscoroutinefunction = None # type: ignore


try:
from sentry_sdk.integrations.django.asgi import wrap_async_view
except (ImportError, SyntaxError):
wrap_async_view = None # type: ignore
from sentry_sdk.integrations.django.asgi import iscoroutinefunction, wrap_async_view


def patch_views() -> None:
Expand Down Expand Up @@ -62,21 +52,13 @@ def sentry_patched_make_view_atomic(
# efficient way to wrap views (or build a cache?)

integration = sentry_sdk.get_client().get_integration(DjangoIntegration)
if integration is not None:
is_async_view = (
iscoroutinefunction is not None
and wrap_async_view is not None
and iscoroutinefunction(callback)
)
if is_async_view:
sentry_wrapped_callback = wrap_async_view(callback)
else:
sentry_wrapped_callback = _wrap_sync_view(callback)
if integration is None:
return callback

else:
sentry_wrapped_callback = callback
if iscoroutinefunction(callback):
return wrap_async_view(callback)

return sentry_wrapped_callback
return _wrap_sync_view(callback)

SimpleTemplateResponse.render = sentry_patched_render
BaseHandler.make_view_atomic = sentry_patched_make_view_atomic
Expand Down
Loading