ref: Move HTTP client breadcrumbs to integrations (2) - #7131
Conversation
…_breadcrumbs_from_span Store method/URL on HTTPConnection in putrequest() so getresponse() can create breadcrumbs directly without reading span internals. Remove the now-unused maybe_create_breadcrumbs_from_span function and its call site in Span.finish().
…ttp-client-breadcrumbs-2
Codecov Results 📊✅ 98755 passed | ❌ 177 failed | ⏭️ 6474 skipped | Total: 105406 | Pass Rate: 93.69% | Execution Time: 351m 21s 📊 Comparison with Base Branch
➕ New Tests (177)View new tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/django/init.py | 84.21% |
Coverage diff
@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.96% 89.59% -0.37%
==========================================
Files 193 193 —
Lines 24975 25025 +50
Branches 9010 9012 +2
==========================================
+ Hits 22467 22420 -47
- Misses 2508 2605 +97
- Partials 1437 1433 -4Generated by Codecov Action
Description
Move breadcrumbs created by the stdlib HTTP client to the integration itself, instead of relying on span data.
Issues
Part 2/2 of #7067
Reminders
uv run ruff.feat:,fix:,ref:,meta:)