Skip to content

chore: bump actions in ci#2665

Open
bitsandfoxes wants to merge 6 commits intomainfrom
chore/ci-bump-deps
Open

chore: bump actions in ci#2665
bitsandfoxes wants to merge 6 commits intomainfrom
chore/ci-bump-deps

Conversation

@bitsandfoxes
Copy link
Copy Markdown
Contributor

@bitsandfoxes bitsandfoxes commented May 6, 2026

This addresses the 79 warnings that

Node.js 20 actions are deprecated.

which will hit us in June.

#skip-changelog

Copy link
Copy Markdown
Contributor Author

@bitsandfoxes bitsandfoxes May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously relied on this fork https://github.com/vaind/download-artifact (that is in dire need of getting synced), or, like here, we wrap action/download-artifact in 10 lines of bash and call it a day.

@bitsandfoxes bitsandfoxes requested a review from a team May 8, 2026 08:56
@bitsandfoxes bitsandfoxes marked this pull request as ready for review May 8, 2026 08:56
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 977760a. Configure here.

steps:
- name: Checkout
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing actions: read permission for artifact API call

High Severity

The build.yml workflow explicitly restricts permissions to checks: write, statuses: write, and contents: read. When permissions are explicitly listed, all unlisted scopes default to none. The new wait-for-artifact composite action uses gh api to call the Actions REST API (/actions/runs/.../artifacts), which requires actions: read permission on the GITHUB_TOKEN. The old vaind/download-artifact fork used internal runtime APIs (via ACTIONS_RUNTIME_TOKEN) that bypass REST API permission checks, so this wasn't needed before. Without adding actions: read to the permissions block, the gh api call will likely fail with a 403, breaking all four SDK download steps in build.yml.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 977760a. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant