fix(ui): Support keyboard shortcuts on non-US keyboard layouts #104487
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyboard shortcut system was using deprecated keyCode property which doesn't work correctly with different keyboard layouts (like German QWERTZ). On German keyboards, the "/" character requires Shift+7 and has a different keyCode, causing Cmd+/ shortcuts to fail. This change updates the useHotkeys hook to use the modern event.key property for better keyboard layout compatibility, while maintaining backwards compatibility with keyCode for special keys that may not have a key property. The fix ensures that shortcuts like Cmd+/ (used for the Explore panel) now work correctly on German and other non-US keyboards.
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes keyboard shortcuts (specifically
Cmd+/for opening the Explore panel) not working on German and other non-US keyboard layouts.