fix(test): Fix flaky React Native metrics onboarding test#111848
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): Fix flaky React Native metrics onboarding test#111848JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Replace heavy MetricsTabOnboarding render with lightweight renderWithOnboardingLayout helper, matching the pattern used by other metrics spec files. The full component render included page filters and dynamic imports that could exceed the 5s timeout under load. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace heavy
MetricsTabOnboardingrender with the lightweightrenderWithOnboardingLayouthelper, matching the pattern used by other metrics spec files (e.g.dotnet/metrics.spec.tsx).The full component render included page filters, dynamic imports via
useLoadGettingStarted, and multiple API calls that could exceed the 5s Jest timeout under load. TherenderWithOnboardingLayouthelper renders the docs content directly without the full component tree, making the test fast and deterministic.This test failed 2 times on master in the last 30 days with
Exceeded timeout of 5000 ms for a test.Made with Cursor