fix(test): Fix flaky SpanEvidencePreview error state test#111853
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): Fix flaky SpanEvidencePreview error state test#111853JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Use waitFor with a longer timeout for the error text assertion. The hovercard has a render delay and useApiQuery may retry failed requests, causing findByText to time out under CI load. Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use waitFor with a longer timeout for the error text assertion in the SpanEvidencePreview spec.
The hovercard has a render delay (100ms) and useApiQuery may retry failed requests with exponential backoff, causing findByText to time out under CI load. Using waitFor with a 3000ms timeout gives sufficient headroom for the error state to render reliably.
This test failed 2 times on master in the last 30 days.
Made with Cursor