fix(test): Fix flaky ResultsSearchQueryBuilder spec#111854
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): Fix flaky ResultsSearchQueryBuilder spec#111854JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Add {delay: null} to userEvent.type calls to prevent timeouts.
Without this, userEvent types each character with a delay, which
can exceed the 5000ms test timeout under CI load. Also use findByRole
for the listbox to properly await its appearance.
Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add {delay: null} to userEvent.type calls to prevent test timeouts.
Without this option, userEvent types each character with a simulated delay between keystrokes, which can push the total test duration past the 5000ms timeout under CI load. Also use findByRole for the listbox to properly await its async appearance before making assertions.
Two tests in this file were flaking on master (5 occurrences in the last 30 days):
Made with Cursor