fix(test): Fix flaky ResultsSearchQueryBuilder spec#111855
Draft
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Draft
fix(test): Fix flaky ResultsSearchQueryBuilder spec#111855JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Stabilize two flaky tests: 1. "does not show function tags in has: dropdown" — timed out at 5000ms because userEvent.type started typing before async API responses (feature flags, recent searches) had settled, causing re-renders mid-typing that slowed each keystroke. Split into click + findByRole (listbox) + keyboard to let initial renders complete before typing. 2. "shows normal tags in the dropdown" — act() warning from SearchQueryBuilderCombobox because pending state updates from API responses fired after test assertions completed. Add waitFor at end to flush pending React state updates before teardown. Also add MockApiClient.clearMockResponses() in beforeEach to prevent mock leakage between tests. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two flaky tests in
resultsSearchQueryBuilder.spec.tsxthat failed 5 times on master in the last 30 days."does not show function tags in has: dropdown" timed out at 5000ms because
userEvent.typestarted typing before async API responses (feature flags viauseFetchOrganizationFeatureFlags, recent searches) had settled. Re-renders triggered by those responses mid-typing slowed each keystroke. Fixed by splitting intouserEvent.click→findByRole('listbox')→userEvent.keyboardso initial renders complete before typing begins."shows normal tags in the dropdown" failed with act() warnings from
SearchQueryBuilderComboboxbecause pending state updates from API responses fired after test assertions completed, triggering React's act() warning whichjest-fail-on-consolecaught as a failure. Fixed by addingawait waitFor()at the end to flush pending React state updates before teardown.Also added
MockApiClient.clearMockResponses()inbeforeEachto prevent mock leakage between tests.Test plan
Made with Cursor