fix(grouping): Fix int parameterization bugs#111870
Merged
lobsterkatie merged 6 commits intomasterfrom Mar 31, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-fix-int-parameterization-bugs
branch
from
e6e76c2 to
46d3f62
Compare
shashjar
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs with our integer parameterization:
Only count a dash as a minus sign if it doesn't come in between two sets of alphanumeric characters (so
1121-1231comes out as<int>-<int>rather than<int><int>andmaisey-908comes out asmaisey-<int>rather thanmaisey<int>, butdifference:-4anddifference: -4both are correctly parameterized asdifference:<int>anddifference: <int>, respectively).Fix the fact that positive integers count as hex values if they have at least 8 digits, but negative integers still count as integers (no matter how long they are) by restricting the int pattern to 7 characters.
Note that the combination of these fixes (making sure that dashes count as minus signs for negative hex values if they're not part of a dashed string) will require changes to the hex pattern, and so isn't included here. (It will be addressed in an upcoming PR making other hex changes.)