fix(test): stabilize flaky EventGroupingInfo rendering test#111906
fix(test): stabilize flaky EventGroupingInfo rendering test#111906JoshuaKGoldberg merged 1 commit intomasterfrom
Conversation
998e1fd to
085fca0
Compare
085fca0 to
ebf0bdb
Compare
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| /static/app/views/performance/ @getsentry/data-browsing | ||
| /static/app/components/performance/ @getsentry/data-browsing | ||
| /static/app/utils/performance/ @getsentry/data-browsing | ||
| /static/app/components/events/groupingInfo @getsentry/data-browsing |
There was a problem hiding this comment.
[Question] Is there a different team we should put for this? Because this is more of a shared component / issues page point, which is outside of data-browsing, right? ❓
ebf0bdb to
7fda74c
Compare
|
This PR's test is particularly flaky, and showing up in #111860 a lot (e.g. https://github.com/getsentry/sentry/actions/runs/23913904794/job/69742763778?pr=111860). I'm going to draft this PR, retarget to |
d0c1c7f to
4bffc8f
Compare
4bffc8f to
23a99ad
Compare
Previously,
groupingInfoSection.spec.tsxwas testing theGroupingInfoSectioncomponent: but all that component does is combine theInterimSectioncomponent with a lazy-loadedGroupingInfocomponent. That lazy-loading can take >=100-150ms locally, and might be the cause of flake in CI.This PR changes the test to:
GroupingInfo, bypassing the lazy-loadFoldSection's unit tests, as rendered byInterimSection)Fixes ENG-7209
Note that CI Jest tests are failing because the Frontend: Rerun Flaky Tests(not yet in use) Known flaky tests should be run many times, just to be safe.
label is causing other, still-flaky tests to be run.Rebased onmasterso theit.isKnownFlake(#111860) addition isn't here yet.Made with Cursor
Co-authored-by: @nikkikapadia