Skip to content

fix(test): stabilize flaky EventGroupingInfo rendering test#111906

Merged
JoshuaKGoldberg merged 1 commit intomasterfrom
fix/flaky-grouping-info-section-spec
Apr 3, 2026
Merged

fix(test): stabilize flaky EventGroupingInfo rendering test#111906
JoshuaKGoldberg merged 1 commit intomasterfrom
fix/flaky-grouping-info-section-spec

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 31, 2026

Previously, groupingInfoSection.spec.tsx was testing the GroupingInfoSection component: but all that component does is combine the InterimSection component with a lazy-loaded GroupingInfo component. That lazy-loading can take >=100-150ms locally, and might be the cause of flake in CI.

This PR changes the test to:

  • Directly test GroupingInfo, bypassing the lazy-load
  • Delete the specific flaky test that was checking for the component being loaded after click (since that's covered by FoldSection's unit tests, as rendered by InterimSection)

Fixes ENG-7209

Note that CI Jest tests are failing because the Frontend: Rerun Flaky Tests (not yet in use) Known flaky tests should be run many times, just to be safe. label is causing other, still-flaky tests to be run. Rebased on master so the it.isKnownFlake (#111860) addition isn't here yet.

Made with Cursor

Co-authored-by: @nikkikapadia

@JoshuaKGoldberg JoshuaKGoldberg added Scope: Frontend Automatically applied to PRs that change frontend components Frontend: Rerun Flaky Tests (not yet in use) Known flaky tests should be run many times, just to be safe. labels Mar 31, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(test): Fix flaky EventGroupingInfo rendering test fix(test): stabilize flaky EventGroupingInfo rendering test Mar 31, 2026
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 1, 2026

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-grouping-info-section-spec branch from 998e1fd to 085fca0 Compare April 1, 2026 20:43
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-grouping-info-section-spec branch from 085fca0 to ebf0bdb Compare April 1, 2026 20:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

/static/app/views/performance/ @getsentry/data-browsing
/static/app/components/performance/ @getsentry/data-browsing
/static/app/utils/performance/ @getsentry/data-browsing
/static/app/components/events/groupingInfo @getsentry/data-browsing
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Is there a different team we should put for this? Because this is more of a shared component / issues page point, which is outside of data-browsing, right? ❓

@JoshuaKGoldberg JoshuaKGoldberg requested review from a team and removed request for shayna-ch April 1, 2026 20:52
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 1, 2026 20:55
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner April 1, 2026 20:55
Copy link
Copy Markdown
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@JoshuaKGoldberg
Copy link
Copy Markdown
Member Author

This PR's test is particularly flaky, and showing up in #111860 a lot (e.g. https://github.com/getsentry/sentry/actions/runs/23913904794/job/69742763778?pr=111860). I'm going to draft this PR, retarget to master, and merge this PR first.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 2, 2026 18:59
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-grouping-info-section-spec branch from d0c1c7f to 4bffc8f Compare April 3, 2026 13:46
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from fix/flaky-test-rerun-infra to master April 3, 2026 13:46
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix/flaky-grouping-info-section-spec branch from 4bffc8f to 23a99ad Compare April 3, 2026 13:47
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 3, 2026 14:26
@JoshuaKGoldberg JoshuaKGoldberg removed the Frontend: Rerun Flaky Tests (not yet in use) Known flaky tests should be run many times, just to be safe. label Apr 3, 2026
@JoshuaKGoldberg JoshuaKGoldberg merged commit c3e6a7f into master Apr 3, 2026
73 of 75 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix/flaky-grouping-info-section-spec branch April 3, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants