Skip to content

ref(flags): Remove organizations:replay-details-eap-query #116642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wedamija wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −462
Open

ref(flags): Remove organizations:replay-details-eap-query #116642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:replay-ai-summaries-mobile", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable replay AI summaries for web replays
manager.add("organizations:replay-ai-summaries", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable reading replay details using EAP query
manager.add("organizations:replay-details-eap-query", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Enable using the events replays dataset
manager.add("organizations:events-use-replays-dataset", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Enable using the events api with a sql interface
Expand Down
232 changes: 8 additions & 224 deletions src/sentry/replays/endpoints/organization_replay_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,10 @@
import uuid
from datetime import datetime, timezone
from typing import TypedDict

from drf_spectacular.utils import extend_schema
from rest_framework.request import Request
from rest_framework.response import Response
from snuba_sdk import (
Column,
Condition,
Direction,
Entity,
Function,
Granularity,
Op,
OrderBy,
Query,
)

from sentry import features
from sentry.api.api_publish_status import ApiPublishStatus
from sentry.api.base import cell_silo_endpoint
from sentry.api.bases.organization import NoProjects
Expand All @@ -28,8 +15,6 @@
from sentry.constants import ALL_ACCESS_PROJECTS
from sentry.models.organization import Organization
from sentry.replays.endpoints.organization_replay_endpoint import OrganizationReplayEndpoint
from sentry.replays.lib.eap import read as eap_read
from sentry.replays.lib.eap.snuba_transpiler import RequestMeta, Settings
from sentry.replays.post_process import ReplayDetailsResponse, process_raw_response
from sentry.replays.query import query_replay_instance
from sentry.replays.validators import ReplayValidator
Expand All @@ -39,186 +24,6 @@ class GetReplayResponse(TypedDict):
data: ReplayDetailsResponse


def _query_replay_urls_eap(
replay_id: str,
project_ids: list[int],
start: datetime,
end: datetime,
organization_id: int,
) -> list[str]:
"""Query URLs for a replay from EAP breadcrumb events."""
replay_id_no_dashes = replay_id.replace("-", "")

first_seen_agg = Function("min", parameters=[Column("sentry.timestamp")], alias="first_seen")

select = [
Column("to"),
first_seen_agg,
]

snuba_query = Query(
match=Entity("replays"),
select=select,
where=[
Condition(Column("replay_id"), Op.EQ, replay_id_no_dashes),
Condition(Column("category"), Op.EQ, "navigation"),
],
groupby=[Column("to")],
orderby=[OrderBy(first_seen_agg, Direction.ASC)],
)

settings = Settings(
attribute_types={
"replay_id": str,
"category": str,
"sentry.timestamp": float,
"to": str,
},
default_limit=1000,
default_offset=0,
)

request_meta = RequestMeta(
cogs_category="replays",
debug=False,
start_datetime=start,
end_datetime=end,
organization_id=organization_id,
project_ids=project_ids,
referrer="replays.query.urls",
request_id=str(uuid.uuid4().hex),
trace_item_type="replay",
)

result = eap_read.query(snuba_query, settings, request_meta, [])

urls: list[str] = []
for row in result.get("data", []):
url = row.get("to")
if url and isinstance(url, str):
urls.append(url)

return urls


def _normalize_eap_response(data: list[dict]) -> list[dict]:
"""Normalize EAP response data for frontend compatibility.

- Convert float timestamps to ISO strings
- Convert agg_project_id from float to int
"""
for item in data:
if "started_at" in item and isinstance(item["started_at"], float):
item["started_at"] = datetime.fromtimestamp(
item["started_at"], tz=timezone.utc
).isoformat()
if "finished_at" in item and isinstance(item["finished_at"], float):
item["finished_at"] = datetime.fromtimestamp(
item["finished_at"], tz=timezone.utc
).isoformat()

# Convert project_id from float to int to avoid ".0" in output
if "agg_project_id" in item and isinstance(item["agg_project_id"], float):
item["agg_project_id"] = int(item["agg_project_id"])
return data


def query_replay_instance_eap(
project_ids: list[int],
replay_ids: list[str],
start: datetime,
end: datetime,
organization_id: int,
request_user_id: int | None,
referrer: str = "replays.query.details_query",
):
# EAP stores replay_id in hex without dashes
replay_ids_no_dashes = [replay_id.replace("-", "") for replay_id in replay_ids]

select = [
Column("replay_id"),
Function("min", parameters=[Column("sentry.project_id")], alias="agg_project_id"),
Function("min", parameters=[Column("sentry.timestamp")], alias="started_at"),
Function("max", parameters=[Column("sentry.timestamp")], alias="finished_at"),
Function("count", parameters=[Column("segment_id")], alias="count_segments"),
Function("sum", parameters=[Column("count_error_events")], alias="count_errors"),
Function("sum", parameters=[Column("count_warning_events")], alias="count_warnings"),
Function("sum", parameters=[Column("count_info_events")], alias="count_infos"),
Function(
"sumIf",
parameters=[
Column("click_is_dead"),
Function(
"greaterOrEquals",
[
Column("sentry.timestamp"),
int(datetime(year=2023, month=7, day=24).timestamp()),
],
),
],
alias="count_dead_clicks",
),
Function(
"sumIf",
parameters=[
Column("click_is_rage"),
Function(
"greaterOrEquals",
[
Column("sentry.timestamp"),
int(datetime(year=2023, month=7, day=24).timestamp()),
],
),
],
alias="count_rage_clicks",
),
Function("max", parameters=[Column("is_archived")], alias="isArchived"),
]

snuba_query = Query(
match=Entity("replays"),
select=select,
where=[
Condition(Column("replay_id"), Op.IN, replay_ids_no_dashes),
],
groupby=[Column("replay_id")],
granularity=Granularity(3600),
)

settings = Settings(
attribute_types={
"replay_id": str,
"sentry.project_id": int,
"sentry.timestamp": float,
"segment_id": int,
"is_archived": int,
"count_error_events": int,
"count_warning_events": int,
"count_info_events": int,
"click_is_dead": int,
"click_is_rage": int,
},
default_limit=100,
default_offset=0,
)

request_meta = RequestMeta(
cogs_category="replays",
debug=False,
start_datetime=start,
end_datetime=end,
organization_id=organization_id,
project_ids=project_ids,
referrer=referrer,
request_id=str(uuid.uuid4().hex),
trace_item_type="replay",
)
result = eap_read.query(snuba_query, settings, request_meta, [])
# Normalize EAP-specific data types (floats -> ints/ISO strings)
result["data"] = _normalize_eap_response(result["data"])
return result


@cell_silo_endpoint
@extend_schema(tags=["Replays"])
class OrganizationReplayDetailsEndpoint(OrganizationReplayEndpoint):
Expand Down Expand Up @@ -269,35 +74,14 @@ def get(
projects = self.get_projects(request, organization, include_all_accessible=True)
project_ids = [project.id for project in projects]

# Use EAP query if feature flag is enabled
if features.has("organizations:replay-details-eap-query", organization, actor=request.user):
snuba_response = query_replay_instance_eap(
project_ids=project_ids,
replay_ids=[replay_id],
start=filter_params["start"],
end=filter_params["end"],
organization_id=organization.id,
request_user_id=request.user.id,
)["data"]

if snuba_response:
urls = _query_replay_urls_eap(
replay_id=replay_id,
project_ids=project_ids,
start=filter_params["start"],
end=filter_params["end"],
organization_id=organization.id,
)
snuba_response[0]["urls_sorted"] = urls
else:
snuba_response = query_replay_instance(
project_id=project_ids,
replay_id=replay_id,
start=filter_params["start"],
end=filter_params["end"],
organization=organization,
request_user_id=request.user.id,
)
snuba_response = query_replay_instance(
project_id=project_ids,
replay_id=replay_id,
start=filter_params["start"],
end=filter_params["end"],
organization=organization,
request_user_id=request.user.id,
)

replay_data = process_raw_response(
snuba_response,
Expand Down
Loading
Loading