ref(integrations): type IntegrationSerializer response shapes#116654
Open
cvxluo wants to merge 1 commit into
Open
ref(integrations): type IntegrationSerializer response shapes#116654cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
force-pushed
the
cvxluo/type-integrationserializer-response-shapes
branch
from
64b7069 to
f0f0149
Compare
cvxluo
commented
Jun 2, 2026
| return data | ||
|
|
||
| data.update({"configOrganization": []}) | ||
| return {**base} |
Contributor
Author
There was a problem hiding this comment.
i'm not sure if i can avoid some weird typing tricks here. the problem is configOrganization and createIssueConfig are both optional, but returning base directly would be returning a IntegrationSerializerResponse, which fails typing. i figure this is relatively consistent with the rest of the codebase, and we can revisit if it continues to be problematic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
IntegrationSerializer, in preparation for publishing the group integration details endpoint.