Skip to content

ref(flags): Graduate organizations:integrations-github-copilot-agent#116655

Open
wedamija wants to merge 1 commit into
masterfrom
flag-cleanup/organizations-integrations-github-copilot-agent
Open

ref(flags): Graduate organizations:integrations-github-copilot-agent#116655
wedamija wants to merge 1 commit into
masterfrom
flag-cleanup/organizations-integrations-github-copilot-agent

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented Jun 1, 2026

GA flag rolled out to 100%. Remove the flag and make the gated behavior unconditional.

GA flag rolled out to 100%. Remove the flag and make the gated
behavior unconditional.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wedamija wedamija requested a review from JoshFerge June 1, 2026 23:54
@wedamija wedamija requested a review from a team as a code owner June 1, 2026 23:54
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14155ba. Configure here.

from requests import HTTPError
from rest_framework.exceptions import PermissionDenied, ValidationError

from sentry import features
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not updated after removing features import

High Severity

The from sentry import features import was removed from coding_agent_handoff.py, but the corresponding test file tests/sentry/seer/agent/test_coding_agent_handoff.py was not updated. Five tests still patch sentry.seer.agent.coding_agent_handoff.features.has, which will raise AttributeError since features is no longer an attribute of the module. Additionally, test_raises_permission_denied_when_copilot_not_enabled asserts behavior (raising PermissionDenied when the feature flag is off) that was intentionally removed in this commit and will never pass.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 14155ba. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Backend Test Failures

Failures on 8fcb5cc in this run:

tests/sentry/seer/agent/test_coding_agent_handoff.py::TestLaunchCodingAgents::test_copilot_not_licensed_403_returns_github_copilot_not_licensed_failure_typelog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
             ^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1479: in __enter__
    self.target = self.getter()
                  ^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/pkgutil.py:528: in resolve_name
    result = getattr(result, p)
             ^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'sentry.seer.agent.coding_agent_handoff' has no attribute 'features'
tests/sentry/seer/agent/test_coding_agent_handoff.py::TestResolveClient::test_raises_permission_denied_when_copilot_not_enabledlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
             ^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1479: in __enter__
    self.target = self.getter()
                  ^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/pkgutil.py:528: in resolve_name
    result = getattr(result, p)
             ^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'sentry.seer.agent.coding_agent_handoff' has no attribute 'features'
tests/sentry/seer/agent/test_coding_agent_handoff.py::TestResolveClient::test_raises_permission_denied_when_no_copilot_tokenlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
             ^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1479: in __enter__
    self.target = self.getter()
                  ^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/pkgutil.py:528: in resolve_name
    result = getattr(result, p)
             ^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'sentry.seer.agent.coding_agent_handoff' has no attribute 'features'
tests/sentry/integrations/api/endpoints/test_organization_coding_agents.py::OrganizationCodingAgentsPostParameterValidationTest::test_invalid_providerlog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/api/endpoints/test_organization_coding_agents.py:481: in test_invalid_provider
    assert "GitHub Copilot is not enabled" in response.data["detail"]
E   AssertionError: assert 'GitHub Copilot is not enabled' in ErrorDetail(string='GitHub Copilot requires user authorization. Please connect your GitHub account.', code='permission_denied')
tests/sentry/seer/agent/test_coding_agent_handoff.py::TestResolveClient::test_raises_permission_denied_when_copilot_no_user_idlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
             ^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1479: in __enter__
    self.target = self.getter()
                  ^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/pkgutil.py:528: in resolve_name
    result = getattr(result, p)
             ^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'sentry.seer.agent.coding_agent_handoff' has no attribute 'features'
tests/sentry/seer/agent/test_coding_agent_handoff.py::TestResolveClient::test_returns_client_for_github_copilotlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
             ^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1479: in __enter__
    self.target = self.getter()
                  ^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/pkgutil.py:528: in resolve_name
    result = getattr(result, p)
             ^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'sentry.seer.agent.coding_agent_handoff' has no attribute 'features'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant