Skip to content

ref(flags): Graduate organizations:integrations-github_enterprise-project-management#116656

Open
wedamija wants to merge 1 commit into
masterfrom
flag-cleanup/organizations-integrations-github_enterprise-project-management
Open

ref(flags): Graduate organizations:integrations-github_enterprise-project-management#116656
wedamija wants to merge 1 commit into
masterfrom
flag-cleanup/organizations-integrations-github_enterprise-project-management

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented Jun 1, 2026

GA flag rolled out to 100%. Remove the flag and make the gated behavior unconditional.

…ject-management

GA flag rolled out to 100%. Remove the flag and make the gated
behavior unconditional.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wedamija wedamija requested a review from a team June 1, 2026 23:56
@wedamija wedamija requested a review from a team as a code owner June 1, 2026 23:56
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 1, 2026
Comment on lines 137 to 142
# API-driven integration setup pipeline (per-provider rollout)
# ...
# Project Management Integrations Feature Parity Flags
manager.add("organizations:integrations-github_enterprise-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
manager.add("organizations:integrations-gitlab-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Temporary: log full Jira Cloud `issue.updated` webhook payloads so we can design project-change link rewriting.
manager.add("organizations:jira-issue-updated-payload-logging", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The check_feature_flag method in GitHubIssueSyncSpec still references the removed organizations:integrations-github_enterprise-project-management flag, which will break GitHub Enterprise issue syncing.
Severity: CRITICAL

Suggested Fix

The call to check_feature_flag() in get_resolve_sync_action() within src/sentry/integrations/github/issue_sync.py should be removed. The logic should be made unconditional to reflect the feature flag's graduation, similar to the changes made in src/sentry/integrations/utils/sync.py.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/sentry/features/temporary.py#L137-L142

Potential issue: The removal of the
`organizations:integrations-github_enterprise-project-management` feature flag from
`src/sentry/features/temporary.py` was incomplete. A reference to this flag remains in
`src/sentry/integrations/github/issue_sync.py` within the `check_feature_flag` method.
Because the flag is no longer registered, the `features.has()` call will catch a
`FeatureNotRegistered` exception and return `False`. This causes
`get_resolve_sync_action()` to always return `ResolveSyncAction.NOOP`, which will
silently disable issue status synchronization (resolve/unresolve) from GitHub webhooks
for all GitHub Enterprise integrations.

Also affects:

  • src/sentry/integrations/utils/sync.py:43~49

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Backend Test Failures

Failures on 1b83f17 in this run:

tests/sentry/issues/escalating/test_escalating.py::HistoricGroupCounts::test_query_single_grouplog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/issues/escalating/test_escalating.py:92: in test_query_single_group
    assert query_groups_past_counts(Group.objects.all()) == [
E   AssertionError: assert [] == [{'count()': ...236675997712}]
E     
E     Right contains one more item: �[0m{�[33m'�[39;49;00m�[33mcount()�[39;49;00m�[33m'�[39;49;00m: �[94m1�[39;49;00m, �[33m'�[39;49;00m�[33mgroup_id�[39;49;00m�[33m'�[39;49;00m: �[94m64�[39;49;00m, �[33m'�[39;49;00m�[33mhourBucket�[39;49;00m�[33m'�[39;49;00m: �[33m'�[39;49;00m�[33m2026-06-01T06:00:00+00:00�[39;49;00m�[33m'�[39;49;00m, �[33m'�[39;49;00m�[33mproject_id�[39;49;00m�[33m'�[39;49;00m: �[94m4558236675997712�[39;49;00m}�[90m�[39;49;00m
E     
E     Full diff:
E     �[0m�[92m+ []�[39;49;00m�[90m�[39;49;00m
E     �[91m- [�[39;49;00m�[90m�[39;49;00m
E     �[91m-     {�[39;49;00m�[90m�[39;49;00m
E     �[91m-         'count()': 1,�[39;49;00m�[90m�[39;49;00m
E     �[91m-         'group_id': 64,�[39;49;00m�[90m�[39;49;00m
E     �[91m-         'hourBucket': '2026-06-01T06:00:00+00:00',�[39;49;00m�[90m�[39;49;00m
E     �[91m-         'project_id': 4558236675997712,�[39;49;00m�[90m�[39;49;00m
E     �[91m-     },�[39;49;00m�[90m�[39;49;00m
E     �[91m- ]�[39;49;00m�[90m�[39;49;00m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant