ref(flags): Graduate organizations:integrations-github_enterprise-project-management#116656
Open
wedamija wants to merge 1 commit into
Open
Conversation
…ject-management GA flag rolled out to 100%. Remove the flag and make the gated behavior unconditional. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment on lines
137
to
142
| # API-driven integration setup pipeline (per-provider rollout) | ||
| # ... | ||
| # Project Management Integrations Feature Parity Flags | ||
| manager.add("organizations:integrations-github_enterprise-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| manager.add("organizations:integrations-gitlab-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| # Temporary: log full Jira Cloud `issue.updated` webhook payloads so we can design project-change link rewriting. | ||
| manager.add("organizations:jira-issue-updated-payload-logging", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False) |
Contributor
There was a problem hiding this comment.
Bug: The check_feature_flag method in GitHubIssueSyncSpec still references the removed organizations:integrations-github_enterprise-project-management flag, which will break GitHub Enterprise issue syncing.
Severity: CRITICAL
Suggested Fix
The call to check_feature_flag() in get_resolve_sync_action() within src/sentry/integrations/github/issue_sync.py should be removed. The logic should be made unconditional to reflect the feature flag's graduation, similar to the changes made in src/sentry/integrations/utils/sync.py.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/features/temporary.py#L137-L142
Potential issue: The removal of the
`organizations:integrations-github_enterprise-project-management` feature flag from
`src/sentry/features/temporary.py` was incomplete. A reference to this flag remains in
`src/sentry/integrations/github/issue_sync.py` within the `check_feature_flag` method.
Because the flag is no longer registered, the `features.has()` call will catch a
`FeatureNotRegistered` exception and return `False`. This causes
`get_resolve_sync_action()` to always return `ResolveSyncAction.NOOP`, which will
silently disable issue status synchronization (resolve/unresolve) from GitHub webhooks
for all GitHub Enterprise integrations.
Also affects:
src/sentry/integrations/utils/sync.py:43~49
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GA flag rolled out to 100%. Remove the flag and make the gated behavior unconditional.