Skip to content

ci: Replace custom JEST_TEST_BALANCER env var with --testResultsProcessor#116661

Merged
ryan953 merged 1 commit into
masterfrom
ryan953/ci-jest-balancer-testResultsProcessor
Jun 2, 2026
Merged

ci: Replace custom JEST_TEST_BALANCER env var with --testResultsProcessor#116661
ryan953 merged 1 commit into
masterfrom
ryan953/ci-jest-balancer-testResultsProcessor

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Jun 2, 2026

It seemed like the env-var was really only used to restrict this command pnpm run test-ci from being run locally with tests/js/test-balancer/index.js involved.

Before jest-balance.json was committed to the repo, so preventing people from updating and committing it by accident was a good idea.
But, we don't need that anymore because we run the balancer in CI and the output is automatically captured and stashed in a github artifact for other CI runs to use. So it's actually a benefit to run things locally as we can test that the output jest-balance.json contains reasonable data inside.

@ryan953 ryan953 requested review from a team as code owners June 2, 2026 03:16
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.59%

@ryan953 ryan953 merged commit 996a53a into master Jun 2, 2026
77 checks passed
@ryan953 ryan953 deleted the ryan953/ci-jest-balancer-testResultsProcessor branch June 2, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants