ci: Replace custom JEST_TEST_BALANCER env var with --testResultsProcessor#116661
Merged
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
joshuarli
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed like the env-var was really only used to restrict this command
pnpm run test-cifrom being run locally withtests/js/test-balancer/index.jsinvolved.Before
jest-balance.jsonwas committed to the repo, so preventing people from updating and committing it by accident was a good idea.But, we don't need that anymore because we run the balancer in CI and the output is automatically captured and stashed in a github artifact for other CI runs to use. So it's actually a benefit to run things locally as we can test that the output
jest-balance.jsoncontains reasonable data inside.