feat: seer drawer pictureInPicture#116670
Draft
TkDodo wants to merge 10 commits into
Draft
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.59% |
natemoo-re
reviewed
Jun 2, 2026
Comment on lines
+62
to
+64
| const nodes = source.querySelectorAll<HTMLLinkElement | HTMLStyleElement>( | ||
| 'link[rel="stylesheet"], style' | ||
| ); |
Member
There was a problem hiding this comment.
Any particular reason not to use CSSOM here? Not sure if we can tell what comes from emotion there.
Member
There was a problem hiding this comment.
I'm also not seeing Rubik loading, maybe we need to copy that resource over too?
Comment on lines
+74
to
+77
| .then(() => closeDrawer()) | ||
| .catch(() => { | ||
| // Failed to open the PiP window — keep the drawer open. | ||
| }); |
Member
There was a problem hiding this comment.
It would be nice to sync the width back to drawerWidth on close here
| const drawerWidth = rootRef.current?.getBoundingClientRect().width; | ||
| requestPipWindow({ | ||
| width: drawerWidth ? Math.round(drawerWidth) : 480, | ||
| height: Math.round(window.innerHeight * 0.9), |
Member
There was a problem hiding this comment.
I'm seeing the PIP window height constrained to a max height? Unclear if this is just how Chrome implements the popout window?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows popping out the seer drawer into a picture-in-picture window using the document picture in picture API