feat(api): migrate Tag(Key|Value)Serializer to Serializer[T]

src/sentry/issues/endpoints/group_tagkey_details.py

@@ -66,7 +66,7 @@ class GroupTagKeyDetailsEndpoint(GroupEndpoint):
         examples=[TagsExamples.GROUP_TAGKEY_DETAILS],
     )
     @deprecated(CELL_API_DEPRECATION_DATE, url_names=["sentry-api-0-group-tag-key-details"])
-    def get(self, request: Request, group, key) -> Response:
+    def get(self, request: Request, group, key) -> Response[TagKeySerializerResponse]:
         """
         Returns the values and aggregate details of a given tag key related to an issue.
         """

src/sentry/tagstore/base.py

@@ -11,7 +11,7 @@
 
 if TYPE_CHECKING:
     from sentry.models.group import Group
-    from sentry.tagstore.types import GroupTagValue
+    from sentry.tagstore.types import GroupTagKey, GroupTagValue, TagKey
 
 # Valid pattern for tag key names
 TAG_KEY_RE = re.compile(r"^[a-zA-Z0-9_\.:-]+$")
@@ -152,7 +152,7 @@ def get_group_tag_key(
         environment_id,
         key: str,
         tenant_ids=None,
-    ):
+    ) -> GroupTagKey | TagKey:
         """
         >>> get_group_tag_key(group, 3, "key1")
         """

src/sentry/tagstore/snuba/backend.py

@@ -240,7 +240,7 @@ def __call__(
 
 class _ValueCallable[U](Protocol):
     def __call__(
-        self, *, key: str, value: object, times_seen: int, first_seen: datetime, last_seen: datetime
+        self, *, key: str, value: str, times_seen: int, first_seen: datetime, last_seen: datetime
     ) -> U: ...
 
 
@@ -804,7 +804,7 @@ def get_group_tag_key(
         key,
         tenant_ids=None,
         **kwargs,
-    ):
+    ) -> GroupTagKey | TagKey:
         return self.__get_tag_key_and_top_values(
             group.project_id,
             group,

src/sentry/tagstore/types.py

@@ -58,7 +58,7 @@ def __init__(
         values_seen: int | None = None,
         status: int = TagKeyStatus.ACTIVE,
         count: int | None = None,
-        top_values=None,
+        top_values: tuple[TagValue, ...] | None = None,
     ):
         self.key = key
         self.values_seen = values_seen
@@ -142,7 +142,7 @@ class TagKeySerializerResponse(TagKeySerializerResponseOptional):
 
 @register(GroupTagKey)
 @register(TagKey)
-class TagKeySerializer(Serializer):
+class TagKeySerializer(Serializer[TagKeySerializerResponse]):
     def serialize(self, obj, attrs, user, **kwargs) -> TagKeySerializerResponse:
         from sentry import tagstore
 
@@ -175,7 +175,7 @@ class TagValueSerializerResponse(TagValueSerializerResponseOptional):
 
 @register(GroupTagValue)
 @register(TagValue)
-class TagValueSerializer(Serializer):
+class TagValueSerializer(Serializer[TagValueSerializerResponse]):
     def serialize(self, obj, attrs, user, **kwargs) -> TagValueSerializerResponse:
         from sentry import tagstore
 

tests/sentry/issues/endpoints/test_group_tagkey_values.py

@@ -189,6 +189,7 @@ def test_includes_empty_values_backend_helpers(self) -> None:
             "foo",
             tenant_ids={"organization_id": group.project.organization_id},
         )
+        assert group_tag_key.top_values is not None
         top_values = {tv.value for tv in group_tag_key.top_values}
         assert top_values == {"", "bar"}
 

tests/snuba/tagstore/test_tagstore_backend.py

@@ -1215,6 +1215,7 @@ def test_eap_read_path(self) -> None:
 
             assert gk.key == "foo"
             assert gk.values_seen == 1
+            assert gk.top_values is not None
             assert gk.top_values[0].value == "bar"