feat(api): tighten Response[T] on 14 endpoints (typed cohort)#116800
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
azulus
force-pushed
the
jeremy/response-annotation-sweep
branch
from
59caf07 to
2c9210f
Compare
gricha
approved these changes
Jun 3, 2026
Three patterns, source-typing only — no cast(), no behavior change: annotation-only where the body matched the declared T; union with ValidationErrorResponse + as_validation_errors() for the `Response(serializer.errors, 400)` path; one Serializer[T] subscript on ExternalActorSerializer to unlock typed-overload resolution. Round 5 of the rollout — same shape as #116717 / #116736 / #116743.
azulus
force-pushed
the
jeremy/response-annotation-sweep
branch
from
2c9210f to
cc1f5ca
Compare
Member
Author
|
codeql issue is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten 14 endpoints from
-> Responseto-> Response[T]. Source-typing only — nocast(), no behavior change.Three patterns: annotation-only where the body already matches the declared T;
Response[T] | Response[ValidationErrorResponse]with theas_validation_errors()helper for endpoints whose 400 path returnsserializer.errors; one missingSerializer[T]subscript onExternalActorSerializerto unlock typed-overload resolution.Round 5 of the rollout — same shape as #116717 / #116736 / #116743.